From: Markus Elfring <Markus.Elfring@web.de>
To: Charles Han <hanchunchao@inspur.com>,
linux-pm@vger.kernel.org, Georgi Djakov <djakov@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] interconnect: Add NULL check in icc_clk_register()
Date: Mon, 18 Nov 2024 11:42:22 +0100 [thread overview]
Message-ID: <3918d367-e29b-405c-a58a-7c4e813c3cff@web.de> (raw)
In-Reply-To: <20241118095939.49612-1-hanchunchao@inspur.com>
> devm_kasprintf() can return a NULL pointer on failure,but this
> returned value in icc_clk_register() is not checked.
> Add NULL check in icc_clk_register(), to handle kernel NULL
> pointer dereference error.
Another wording suggestion:
devm_kasprintf() calls can return a null pointer on failure.
But such a return value was not checked in this function implementation.
Thus add corresponding checks so that null pointer dereferences
will be avoided.
Regards,
Markus
prev parent reply other threads:[~2024-11-18 10:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 9:59 [PATCH] interconnect: Add NULL check in icc_clk_register Charles Han
2024-11-18 10:42 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3918d367-e29b-405c-a58a-7c4e813c3cff@web.de \
--to=markus.elfring@web.de \
--cc=djakov@kernel.org \
--cc=hanchunchao@inspur.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox