From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756319AbbCCLep (ORCPT ); Tue, 3 Mar 2015 06:34:45 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:58204 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756136AbbCCLen (ORCPT ); Tue, 3 Mar 2015 06:34:43 -0500 From: Arnd Bergmann To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, jassisinghbrar@gmail.com, devicetree@vger.kernel.org Subject: Re: [PATCH 3/3] mailbox: Add support for ST's Mailbox IP Date: Tue, 03 Mar 2015 12:34:37 +0100 Message-ID: <3926609.Ff6LCkuuMX@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1425379283-1567-4-git-send-email-lee.jones@linaro.org> References: <1425379283-1567-1-git-send-email-lee.jones@linaro.org> <1425379283-1567-4-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:kHr0YvNC0jcsMLcjWwRsF2kxEHhAW8lKyt44E2MWK1mnrbGgquH yy3jaAzjUGQw6GUf93NbJ6nO4CacfhrseNgZqx20eL2gAoSpfehnrdhgVQ5xOzw+D/Zyhui vS8tE0CmTnuZEtO5PDlDM6WzDv22aqnJO6leo7eJdL490UjG0vrZ2BPIxMkSg9z+QHwkAxi k0j4XLcZ6oAcXIrdMw8Qw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 03 March 2015 10:41:23 Lee Jones wrote: > + > +/* > + * struct sti_mbox_msg - sti mailbox message description > + * @dsize: data payload size > + * @pdata: message data payload > + */ > +struct sti_mbox_msg { > + u32 dsize; > + u8 *pdata; > +}; As mentioned in another thread, we may just want to add a 'size' argument to the message send function, and a default helper for messages with size of 32 bits. I don't think it's good to fragment this further by adding an indirect message interface in a particular driver. Arnd