From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754249AbcAWRyK (ORCPT ); Sat, 23 Jan 2016 12:54:10 -0500 Received: from gloria.sntech.de ([95.129.55.99]:38086 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753276AbcAWRyH (ORCPT ); Sat, 23 Jan 2016 12:54:07 -0500 From: Heiko Stuebner To: Douglas Anderson Cc: John Youn , balbi@ti.com, kever.yang@rock-chips.com, william.wu@rock-chips.com, huangtao@rock-chips.com, linux-rockchip@lists.infradead.org, Julius Werner , gregory.herrero@intel.com, yousaf.kaukab@intel.com, dinguyen@opensource.altera.com, stern@rowland.harvard.edu, ming.lei@canonical.com, johnyoun@synopsys.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: dwc2: host: Properly set the HFIR Date: Sat, 23 Jan 2016 18:53:37 +0100 Message-ID: <39287239.yyU0LGezZt@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1453506971-31445-1-git-send-email-dianders@chromium.org> References: <1453506971-31445-1-git-send-email-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, 22. Januar 2016, 15:56:10 schrieb Douglas Anderson: > According to the most up to date version of the dwc2 databook, the FRINT > field of the HFIR register should be programmed to: > * 125 us * (PHY clock freq for HS) - 1 > * 1000 us * (PHY clock freq for FS/LS) - 1 > > This is opposed to older versions of the doc that claimed it should be: > * 125 us * (PHY clock freq for HS) > * 1000 us * (PHY clock freq for FS/LS) > > In case you didn't spot it, the difference is the "- 1". > > Let's add the "- 1" to match the newest user manual. It's presumed that > the "- 1" should have always been there and that this was always a > documentation error. If some hardware needs the "- 1" and other > hardware doesn't, we'll have to add a configuration parameter for it in > the future. Same setup and description as in Doug's 21-patch series, so on a veyron-jerry: Tested-by: Heiko Stuebner Heiko