From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Ingo Molnar <mingo@redhat.com>, Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 3/7] kernel-trace: Adjust two checks for null pointers in compatible_field()
Date: Fri, 5 May 2017 23:03:23 +0200 [thread overview]
Message-ID: <392fd14c-1a61-c3de-e5a7-14caaa51be75@users.sourceforge.net> (raw)
In-Reply-To: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 5 May 2017 20:00:11 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written !…
Thus fix the affected source code place.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
kernel/trace/trace_events_hist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index df566e21344d..36412deac24c 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -1324,7 +1324,7 @@ static bool compatible_field(struct ftrace_event_field *field,
{
if (field == test_field)
return true;
- if (field == NULL || test_field == NULL)
+ if (!field || !test_field)
return false;
if (strcmp(field->name, test_field->name) != 0)
return false;
--
2.12.2
next prev parent reply other threads:[~2017-05-05 21:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 21:00 [PATCH 0/7] kernel-trace: Fine-tuning for seven function implementations SF Markus Elfring
2017-05-05 21:01 ` [PATCH 1/7] kernel-trace: Combine two function calls into one in hist_trigger_entry_print() SF Markus Elfring
2017-05-05 21:02 ` [PATCH 2/7] kernel-trace: Replace five seq_puts() calls by seq_putc() SF Markus Elfring
2017-05-05 21:03 ` SF Markus Elfring [this message]
2017-05-23 5:15 ` [PATCH 3/7] kernel-trace: Adjust two checks for null pointers in compatible_field() Steven Rostedt
2017-05-05 21:04 ` [PATCH 4/7] kernel-trace: Improve a size determination in create_hist_field() SF Markus Elfring
2017-05-05 21:05 ` [PATCH 5/7] kernel-trace: Replace two seq_printf() calls by seq_puts() in probes_seq_show() SF Markus Elfring
2017-05-05 21:06 ` [PATCH 0/7] kernel-trace: Fine-tuning for seven function implementations Steven Rostedt
2017-05-05 21:21 ` SF Markus Elfring
2017-05-22 7:45 ` SF Markus Elfring
2017-05-23 5:18 ` Steven Rostedt
2017-05-05 21:06 ` [PATCH 6/7] kernel-trace: Adjust two checks for null pointers in uprobe_buffer_init() SF Markus Elfring
2017-05-05 21:09 ` SF Markus Elfring
2017-05-05 21:10 ` [PATCH 7/7] kernel-trace: Delete an error message for a failed memory allocation in create_trace_uprobe() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=392fd14c-1a61-c3de-e5a7-14caaa51be75@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).