From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755794AbdEEVDf (ORCPT ); Fri, 5 May 2017 17:03:35 -0400 Received: from mout.web.de ([212.227.15.3]:49710 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbdEEVDd (ORCPT ); Fri, 5 May 2017 17:03:33 -0400 Subject: [PATCH 3/7] kernel-trace: Adjust two checks for null pointers in compatible_field() From: SF Markus Elfring To: Ingo Molnar , Steven Rostedt Cc: LKML , kernel-janitors@vger.kernel.org References: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net> Message-ID: <392fd14c-1a61-c3de-e5a7-14caaa51be75@users.sourceforge.net> Date: Fri, 5 May 2017 23:03:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <3419381c-6a8f-f0f6-86e8-3ee7f9af0076@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:Pzv68bLsCb6SfeDk9lFS03h1KTiENa2GTaLWdprHtnjSeEZgI4n /QuZrLcx2qXFQXEyCn672fqwXD7C3sQ2sHxjgUqRb7/1hrkR68c2Zd8dpJw+fjsKf+Aj1Nh BjjE3aLueqg7xydU/NTUwXJSU9wOaf0DUGiIwx46Iilt27s9L7gXoGYXRK9o5HEio3whWQq ++NXfHgXjfvSZkY6JQ59Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:MjnkHI/qQ8s=:iFrZfkN6EYfCZ6BMSFN2r1 Mv+BIuetyCOOMCYz9g9E4UbEDhAw4OpI6ZRz7sWdYiMnpNbBVZuuxgR1IBlMWDvzbMDfssFFO 7lNGRtGM49x6F1qow6JhMjZPz+7YgDBmtsimL9F5hnirHS6Er6kcYe286R56gYp2XW8q57s9E 4HwYKySENJNgJLxAtr/w6wlke/+TYjGZ64Q99fc5kbEohftCNHRketG3d3W8fMfM+RpXWnLD7 JS0fjpRCZsNF7hXvkMmdNB/7FTv9E0kDDtZzm2aM3JcHh6Zz4asBRn1RMNpOZ7paNspyjUq0i wcDOdpIxzkSqPG2MmS05itqzs0CQm7NT8SmR707uE9MxbNYoCuuAjYZwaCwNO+/J8pvviFL46 6OiL0hNCRcgtPBbgbYFBgzuvpXMn+eVZmXgcW2TKw4lNlKB+XDXlvyu9enHIpusEr/EBxM2rl Jzcl077q1TOufWa8+RPucxoCNJgt9jpdbfEM4YBOqVolYpBVmEMi+f1g1gSX97cJ65wi3fOqk /94YM3XqioeGWH71FS++tYLiJ9E+Y8Y1MtAJON/WGkY4e7hnYrzxW+dHnP4+Yi7OHWVUHDkEo vss22wxYY/0nxKyKeRNaJgSePVzkKAcoVRrdCJAWcBRo5jlYu8uFNzvh8lKXbvJyYr0y7fQbG MljGBWvqs8S7eElP59F70WWGWNjdISE69eU8TRoIpbA6xLZWajNpBDOYS4tw16gVVb1nzkLNI TMrS8nkl+1HsRxhbrHP+DnjAaB0HRELDV5lw2t0GItDo2d0/HU5iox60kUuqQNm7D/2LBBwr/ obr9kGs Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 5 May 2017 20:00:11 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code place. Signed-off-by: Markus Elfring --- kernel/trace/trace_events_hist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index df566e21344d..36412deac24c 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -1324,7 +1324,7 @@ static bool compatible_field(struct ftrace_event_field *field, { if (field == test_field) return true; - if (field == NULL || test_field == NULL) + if (!field || !test_field) return false; if (strcmp(field->name, test_field->name) != 0) return false; -- 2.12.2