From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F34A257855 for ; Tue, 19 May 2026 06:59:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779173975; cv=none; b=avdVhdxr2ZbQap+Z3/gi8hAHZtZ+O5CPygbi1TUdotqlqxh049qETNyutwi8kMYX8aYoVIl0JWC2+IIDtS0knejYteBz50iW6AAXdrl+4GCtu0gEq53mmFpyiM5XNzTQ1el7Ew64n2ug86H5R+H6jonpLpWa1+jgL+lNmhspg74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779173975; c=relaxed/simple; bh=0BUhj6j3hrklauwfy+i/h/s8xlX/MYhRh465WVn2hLE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gtmyS21eY4Em3D5tJvT/gKIH8cFGZ/kFR1T84icXufTpHp7N9SeNWFVcunMKFOnNq1npoeYM6ZcRf84AJlERuR9K41BkJzSfWD5PIOvrvPt7SZrPJ2h1R6VYGiD3PtkajgUw3ryEOlc+tXK56s6W2I09ZHKjNChHCCq5Lw6eUlk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MAk4FSBV; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MAk4FSBV" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48e82c23840so24330285e9.3 for ; Mon, 18 May 2026 23:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779173972; x=1779778772; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gF5Z1qKa3/ePayEWJpcu7Cbt4cEhhoyI3/LeiuP7Ies=; b=MAk4FSBVZdYEtSXDCJVHAy6HwIuYO1y7zU9AaEJ23cjjxSOJioRz1BBlFKSs2ns/gB v3iWIZwcegLaqF4IeppnCt7DzcSLc2MresRoCAzV0pKasLnHkys0MihfsEVWVBKOT5ZK +ug0dqRuAmaPBtg8GhJmR7YleUwAvwewy65+l72mU+9/MBjwHk7lR46KafUCsBZTehSm v0SRbEYT5ECZDjIsmqXGw/LiRFHqMQ0aHfFcOIGicUoR2hwFxMuMrmbv+DvjdWNriDOy jQ5mICK1BT3VOGcwqFzJcou47u26sST8mL9k7gSFcry6jMTdcEmiT7mDitDH9+JYDNNB YvNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779173972; x=1779778772; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gF5Z1qKa3/ePayEWJpcu7Cbt4cEhhoyI3/LeiuP7Ies=; b=NON7s49cGx/6pw2QZo5wCXOPzOXFTfUpxNhAu/31FoMrsmLBB/G0qGG4HkgbeQdRmy ZkcZ5V0/ovyFT7g4W+EHCmoAZnBKAzIdAz0z0xUV6cErSlfb2NTVrv9T6dbHTUjbDff/ sLtT+mffIVfkiB9jNuGWR1QF1Junvd6rPZtGiDDO2lJWKZBOz2VTgVM39M37CFgjX62A LRMYt1vM996DDEoN4xlsUVTczq0iQUR2QNiVrd8gppJ7uOlw+uyofuK8ugOx4LGllozy Gp4zh5NqIoqKExUbNqftC3MQZzcJ7FW/l+TZS18rEUrQtaC2Ri3pbCjG67eMagCZohJH AIcQ== X-Forwarded-Encrypted: i=1; AFNElJ8SAh0BrYzcEsr5v5D9EL7IQbmH0nZbqJOKRm+DcjLCzfOF7o6AhGNobhiTLBkcn9exmnXYcfa0dbNkBSQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5i2IAO2G+Lb5Y/rlp9JS01wxUa0kFJxLsQeZjpYXtRtbc4wf8 eelVitpYC8EwZJhlzfu5ft1SA39W1arNzYprWE0g2LEGXc5cRa+8IrGN X-Gm-Gg: Acq92OGV3Pz/ID0bbUAQWIC2ljJrT1cHpu8bc6Gio2iLTov0opU/3GOy0IXXNEtosh+ uZHNkMMUVcY09wM1Bmt3spSGqHcFCmtgaM0ed34ZWUaDzAjuPi6gaqUIoDCHCE89K+2tkTXTfVw P0GAg/SH2vol/9nVMITbBJ65UqqHYkliAyJRpOO1NJG9qzFFlJgbzTo72xqaIo0Hf2JjQIgCUoK HhdgAUGD9NmqYY6+Cd3z7Ib9A4fXK4sRK/Zq9m5QyjxQGxuPdpANM/Sl0QeJtDi+Zu/5Q6997IU GNvJc/J/c5fMdM9rLWmTc//mOBRXtPLPGoho01HeAZFH9LSHiVaNu2GHMNUj5bxBvMjdCoe8g8G FSan8gnjlXWrzu+mvpYYFIW0REGnjQvG1stSuFgZf3IdWkOp613akt8nDVwH/JNq2JV33w2QapR LvSLfMgVYwkPZjYxuq8GzSLLru9AWdS/sGCZc2i1CQQ5EWwHGmd/uPbUm4v0TP6ZCAJIKK X-Received: by 2002:a05:600c:8189:b0:488:ac01:72b6 with SMTP id 5b1f17b1804b1-48fe6323addmr275170575e9.21.1779173971682; Mon, 18 May 2026 23:59:31 -0700 (PDT) Received: from ?IPV6:2a02:3033:6c2:b9c5:ec15:f5ad:b85f:a3b8? ([2a02:3033:6c2:b9c5:ec15:f5ad:b85f:a3b8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4900c16c744sm126227455e9.3.2026.05.18.23.59.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 23:59:31 -0700 (PDT) Message-ID: <3932472e-91aa-400b-a1a4-03f520706890@gmail.com> Date: Tue, 19 May 2026 08:59:19 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] dt-bindings: iio: dac: Add AD5529R To: Jonathan Cameron , Janani Sunil Cc: Lars-Peter Clausen , Michael Hennerich , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, rodrigo.alencar@analog.com References: <20260508-ad5529r-driver-v2-0-e315441685d7@analog.com> <20260508-ad5529r-driver-v2-1-e315441685d7@analog.com> <20260508134843.7646c4f5@jic23-huawei> <20260508140814.67800e4a@jic23-huawei> Content-Language: en-US From: Janani Sunil In-Reply-To: <20260508140814.67800e4a@jic23-huawei> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/8/26 15:08, Jonathan Cameron wrote: > On Fri, 8 May 2026 13:48:43 +0100 > Jonathan Cameron wrote: > >> On Fri, 8 May 2026 13:55:47 +0200 >> Janani Sunil wrote: >> >>> Devicetree bindings for AD5529R 16 channel 12/16 bit high voltage, >>> buffered voltage output digital-to-analog converter (DAC) with an >>> integrated precision reference. >>> >>> Signed-off-by: Janani Sunil >>> --- >>> .../devicetree/bindings/iio/dac/adi,ad5529r.yaml | 96 ++++++++++++++++++++++ >>> MAINTAINERS | 7 ++ >>> 2 files changed, 103 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml >>> new file mode 100644 >>> index 000000000000..f531b4865b01 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml >>> @@ -0,0 +1,96 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/iio/dac/adi,ad5529r.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Analog Devices AD5529R 16-Channel 12/16-bit High Voltage DAC >> How is one device bother 12 and 16-bit? That sometimes happens for >> ADCs where it is really reflecting oversampling or for device with hardware >> FIFOs where storage space is saved by using lower bit rate. I'm not sure either >> applies here. > Having read the driver I now understand. This is supporting two parts and > doing device ID based detection. In an unusual step for Analog they have > the same base part number with a post fix. Whilst this approach works today > it fundamentally breaks fallback dt-compatibles being used in future (the > driver fails for any non match of WHOAMI value as it needs them to look > up device specific data) As such I think you need to have separate > compatibles for the 12 and 16 bit versions. AD5529R supports two variants- AD5529R-12 bit and AD5529R-16 bit. They share the same register interface and pin configuration but differ in DAC resolution. I will add separate compatibles for this case. Best Regards, Janani Sunil