From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABF8B22BAC9 for ; Thu, 16 Jan 2025 22:48:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737067739; cv=none; b=fXpIEKpVevAklp3f3lRMEW2aNaXiteTHCKykA5CEiEpcz1DUEEYcqc+wq1Zl2iUXS9cvhvkDgwarpDUy0l333JzmEYrAbGsjO6IiqrWunAkjk3ZVgrRPjUjjVQ/cm840qIOtZYwukPW0bWeB325Wai/D5+/fj39xlq8wncPu+I4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737067739; c=relaxed/simple; bh=oue/x3nxo+KXuyCUye4CeghGMmHB2bk2b2leGxAQFZU=; h=Message-ID:Content-Type:MIME-Version:In-Reply-To:References: Subject:From:Cc:To:Date; b=MYk4HynKdUZXbbsCYjGwN1HsRg0CREo7UCRmnmix8/urMiWb8rjYp2J949Nj1WLWs45LVLnSWclJ4moJUA8GVrVNNyz6vMLS3cWZcZc0AiMFnWp46oXGl14oazEBeduDilpKJCxh5Mi5hbs8h1UBnJzs1hvp/QKcB0p92tSy8pM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MhNLHx6h; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MhNLHx6h" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11E6AC4CED6; Thu, 16 Jan 2025 22:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737067739; bh=oue/x3nxo+KXuyCUye4CeghGMmHB2bk2b2leGxAQFZU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=MhNLHx6hGWNBa52Q5X84aXJPjmr5SQO0s+Osnr90drfMkE8wsMFAR53xYqkYFRrct fH7FrGY1ie0feqBRNhGtJVQdLyDPzo5NRp7f1hcZWFWwTSliWzMyhNbLphoWoI55Eo YJnEkyoz8YiaSzqI1B/K4SPhs6tM1gVPKQJZ+cvh+rvF4l8qx80kv59QyNG12A0YnJ N+0udJlqT+huBqGCv3cvOakZyIqruwmDJzYuIIxmLiM3dqHlBD5YCQvJzoO6x/w7V8 0my8PCnaILwHrPH1DTdufsfV/ke2zbPHgFv8uX7BBcyeGc+M0NNeR0JXzOMHIEAs8B BRga0qy0zpvlQ== Message-ID: <3933901cddf6c33bbe85e381cae5b3a3.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20250116044907.2947218-1-joe@pf.is.s.u-tokyo.ac.jp> References: <20250116044907.2947218-1-joe@pf.is.s.u-tokyo.ac.jp> Subject: Re: [PATCH] spmi: hisi-spmi-controller: Drop duplicated OF node assignment in spmi_controller_probe() From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, konradybcio@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, marijn.suijten@somainline.org, bjorn.andersson@oss.qualcomm.com, abel.vesa@linaro.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Joe Hattori To: Joe Hattori , mchehab+huawei@kernel.org Date: Thu, 16 Jan 2025 14:48:56 -0800 User-Agent: alot/0.12.dev1+gaa8c22fdeedb Quoting Joe Hattori (2025-01-15 20:49:07) > spmi_controller_probe() assigns a parent device and an OF node to an > SPMI controller. However, the operations are not needed as they are > already assigned in spmi_controller_alloc(). Thus, remove the duplicated > assignments. An unnecessary OF node reference acquisition is also > dropped by this patch. >=20 > Signed-off-by: Joe Hattori > Suggested-by: Stephen Boyd > --- Applied to spmi-next