From: Arnd Bergmann <arnd@arndb.de>
To: Pawel Moll <pawel.moll@arm.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"arm@kernel.org" <arm@kernel.org>,
Mike Turquette <mturquette@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sudeep Holla <Sudeep.Holla@arm.com>
Subject: Re: [PATCH v2 RESEND 1/2] ARM: vexpress: Remove non-DT code
Date: Fri, 28 Nov 2014 17:31:45 +0100 [thread overview]
Message-ID: <3935390.Q4yT7WfqCv@wuerfel> (raw)
In-Reply-To: <1417189984.4371.12.camel@arm.com>
On Friday 28 November 2014 15:53:04 Pawel Moll wrote:
> vmmc-supply is a defined as:
>
> vmmc-supply = <&v2m_fixed_3v3>;
>
> which is:
>
> v2m_fixed_3v3: fixedregulator@0 {
> compatible = "regulator-fixed";
>
> and arch/arm/mach-vexpress/Kconfig says:
>
> menuconfig ARCH_VEXPRESS
> [...]
> select REGULATOR_FIXED_VOLTAGE if REGULATOR
>
> but it doesn't select REGULATOR in result of this discussion:
>
> http://thread.gmane.org/gmane.linux.ports.arm.kernel/223426/focus=223427
>
> To summarize, I believe that setting CONFIG_REGULATOR=y (as in
> vexpress_defconfig) should solve your issue.
Well, there is clearly a bug somewhere. As you say, the mmc driver
now uses the regulator API to check the voltage instead of using
platform_data. But there is no dependency on having the regulator
support around, so it can't.
I would suggest applying your patch from
http://thread.gmane.org/gmane.linux.ports.arm.kernel/223426/focus=224128
after all, or just hardcoding regulator support like a lot of other
platforms do.
Arnd
next prev parent reply other threads:[~2014-11-28 16:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 18:17 [PATCH v2 RESEND 1/2] ARM: vexpress: Remove non-DT code Pawel Moll
2014-11-25 18:17 ` [PATCH 2/2] MAINTAINERS: ARM Versatile Express platform Pawel Moll
2014-11-26 1:54 ` Mike Turquette
2014-11-26 1:59 ` Joe Perches
2014-11-26 12:04 ` Pawel Moll
2014-11-26 12:17 ` Arnd Bergmann
2014-11-26 14:40 ` Pawel Moll
2014-11-26 15:40 ` Joe Perches
2014-11-26 12:13 ` [PATCH v2] " Pawel Moll
2014-11-28 15:14 ` Arnd Bergmann
2014-11-28 17:56 ` Joe Perches
2014-12-01 13:57 ` Pawel Moll
2014-11-28 15:08 ` [PATCH v2 RESEND 1/2] ARM: vexpress: Remove non-DT code Arnd Bergmann
2014-11-28 15:30 ` Russell King - ARM Linux
2014-11-28 15:53 ` Pawel Moll
2014-11-28 16:31 ` Arnd Bergmann [this message]
2014-11-28 16:34 ` Pawel Moll
2014-11-28 16:48 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3935390.Q4yT7WfqCv@wuerfel \
--to=arnd@arndb.de \
--cc=Liviu.Dudau@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Sudeep.Holla@arm.com \
--cc=arm@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox