Re: [PATCH net-next 3/8] net: bcmgenet: use CHECKSUM_COMPLETE for NETIF_F_RXCSUM

Florian Fainelli
2019-12-17T22:52:44Z

On 12/17/19 1:02 PM, Doug Berger wrote:
> This commit updates the Rx checksum offload behavior of the driver
> to use the more generic CHECKSUM_COMPLETE method that supports all
> protocols over the CHECKSUM_UNNECESSARY method that only applies
> to some protocols known by the hardware.
>
> This behavior is perceived to be superior.
>
> Signed-off-by: Doug Berger <opendmb@gmail.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

You could also remove priv->dma_rx_chk_bit which is now write only after
this patch and not used anymore.
--
Florian