Re: [PATCH net-next 3/8] net: bcmgenet: use CHECKSUM_COMPLETE for NETIF_F_RXCSUM

David Miller
2019-12-17T23:21:32Z

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 17 Dec 2019 14:52:07 -0800

> On 12/17/19 1:16 PM, David Miller wrote:
>> From: Doug Berger <opendmb@gmail.com>
>> Date: Tue, 17 Dec 2019 13:02:24 -0800
>>
>>> This commit updates the Rx checksum offload behavior of the driver
>>> to use the more generic CHECKSUM_COMPLETE method that supports all
>>> protocols over the CHECKSUM_UNNECESSARY method that only applies
>>> to some protocols known by the hardware.
>>>
>>> This behavior is perceived to be superior.
>>>
>>> Signed-off-by: Doug Berger <opendmb@gmail.com>
>>
>> This has to be done in the same patch that you change to use
>> the NETIF_F_HW_CSUM feature flag.
>
> Even if we were already advertising support for NETIF_F_RXCSUM before
> patch #2? Not questioning your comment, just trying to understand why
> this is deemed necessary here since it does not affect the same "direction".

My bad... I misunderstood the situation.

Ignore me :-)