From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752055AbcF2VU4 (ORCPT ); Wed, 29 Jun 2016 17:20:56 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:52091 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbcF2VUz (ORCPT ); Wed, 29 Jun 2016 17:20:55 -0400 From: Arnd Bergmann To: Sebastian Reichel Cc: Stephen Boyd , Dmitry Eremin-Solenikov , David Woodhouse , Courtney Cavin , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] power: qcom-smbb: add extcon dependency Date: Wed, 29 Jun 2016 23:16:09 +0200 Message-ID: <3941061.eCNkMs7lBz@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160629210958.GB15422@earth> References: <20160629143056.7405-1-arnd@arndb.de> <57740F1A.5040007@codeaurora.org> <20160629210958.GB15422@earth> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:XjP8ivl/UuWQ/w6utEjgQiv1lJ/+3LZJl9VwK12nAnbKo2rqEn5 dSEO0fkz+J8ooWshdaSHTrCfz+4LRX6V/rPxOWgs2p18y5A4EC0RQ63/VtuLWa9LwY2KUtY YzqMHq3x9Mi8BRW7djd6QkzzNCvYOPfCvQH+eGi11ad9hdLPmzF/Gu6xXgtCJzFUe1gB+Q3 15tmlwsfjkBXovG/08gIA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Hso+EBPcdSA=:767nygDPW+aarZLb+V7pl8 YSVtTWmKkqs2XXDsyKlPv3YSo/LOW+s0aeuE7yPK1Z+ge8Czs2bp6Hs+gUKGZ4vAdw+2Qn3bP D/I28uvknnX80rWCQ+TrBRxW7Roe+k1wxLyOJHBbnLGxV+s8PoZ2X0Y3fTrmtYBV5hTA+gcUj E8v6rblweMh9SxHRudkZq3uIKA+BnONyAZlVPPctWTB259eeox5eyTLxm5TC6QYW5d242vZlv T9+LwY5RWgXN8X7eJajvKUUNSpyastxg/P2T29emT6yqV7OV+XpBzuKldNhJS6yh/qLcwPtNM d6yUPlVDLS+wMvjAeH2YIyXW9gQbkzV6ltPjogSg8QZqPy+Fr10lUYV4PcqayL8FxGHG2hbor EN/QQu0qOSA71z3all69k4ki+LXNvlE1r03IY9TsWLmfMwSVCaanOyd6T2U4wy2h+dSQdKYsn 7aKFPbfbeiWEOz6l06zyKrnwt1mHfmnRE/2HqW+wmYwlJH9dx5BYQ5LEw2hpTpBMl+5S1kMET AEPopzvS7kEJtV8liP1IyiL1p3DB3/A+ReTbkuEQt58rDjvoG/vARr1kQuF4bvUnpgBX2je0e Ffbg2V4b+3O16rklLZ4ppnX7of5QJ9hjqWxoQ6X9l2VFXAA97GYfBTvDVjkaZCqF/gIIAauxB Q0t8RRLClqI6WJR21gBlfKGPB7n4G5ujMCozzdCcVLlB0cG22i8Z91UEdAIWX+1cOHa//tXic PTH2Na+Ngc4DcYA5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, June 29, 2016 11:09:58 PM CEST Sebastian Reichel wrote: > On Wed, Jun 29, 2016 at 11:10:34AM -0700, Stephen Boyd wrote: > > On 06/29/2016 07:38 AM, Sebastian Reichel wrote: > > > On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote: > > >> Building the smbb driver without extcon results in a link failure: > > >> > > >> drivers/power/built-in.o: In function `smbb_usb_valid_handler': > > >> :(.text+0x3190): undefined reference to `extcon_set_cable_state_' > > >> drivers/power/built-in.o: In function `smbb_charger_probe': > > >> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate' > > >> :(.text+0x3898): undefined reference to `devm_extcon_dev_register' > > >> > > >> This adds a Kconfig dependency. > > >> > > >> Signed-off-by: Arnd Bergmann > > >> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver") > > > > extcon use was only recently introduced so this should be > > > > Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable > > detection") > > Right, I didn't notice the Fixes line is wrong. Since I will have to > rebase now, I will just squash this into 0b7fe26ae602. Ok, thanks and sorry for the mixup, I must have pasted the wrong line. Arnd