From: Vignesh R <vigneshr@ti.com>
To: Peter Rosin <peda@axentia.se>, Rob Herring <robh+dt@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: "Nori, Sekhar" <nsekhar@ti.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Menon, Nishanth" <nm@ti.com>, "Kristo, Tero" <t-kristo@ti.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible for AM654 SoCs
Date: Fri, 28 Sep 2018 10:57:18 +0530 [thread overview]
Message-ID: <3943f2b1-3850-ad1e-6318-cfaec0eff485@ti.com> (raw)
In-Reply-To: <c3421929-1c40-513a-5c14-73e132a11d0f@axentia.se>
On Wednesday 26 September 2018 08:14 PM, Peter Rosin wrote:
> On 2018-09-26 13:57, Vignesh R wrote:
>> AM654 SoCs have similar I2C IP as OMAP SoCs. Add new compatible to
>> handle AM654 SoCs.
>>
>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>> ---
>> Documentation/devicetree/bindings/i2c/i2c-omap.txt | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-omap.txt b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
>> index 7e49839d4124..11ce869d682d 100644
>> --- a/Documentation/devicetree/bindings/i2c/i2c-omap.txt
>> +++ b/Documentation/devicetree/bindings/i2c/i2c-omap.txt
>> @@ -2,7 +2,8 @@ I2C for OMAP platforms
>>
>> Required properties :
>> - compatible : Must be "ti,omap2420-i2c", "ti,omap2430-i2c", "ti,omap3-i2c"
>> - or "ti,omap4-i2c"
>> + or "ti,omap4-i2c" for OMAP2+ SoCs
>> +- compatible : Must "ti,am654-i2c", "ti,omap4-i2c" for AM654 SoCs
> ^
> be
>
> Also, it looks bad with two 'compatible' entries in the properties list.
> I think the trend is to list one valid compatible (plus fallbacks)
> per line. So, you should consider reformatting, possibly like so:
>
> - compatible : Must be one of
> "ti,omap2420-i2c"
> "ti,omap2430-i2c"
> "ti,omap3-i2c"
> "ti,omap4-i2c"
> "ti,am654-i2c", "ti,omap4-i2c"
>
I have sent v2 with these changes. Thanks for the review!
--
Regards
Vignesh
next prev parent reply other threads:[~2018-09-28 5:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 11:57 [PATCH 0/2] i2c-omap: Enable i2c-omap driver for AM654 SoCs Vignesh R
2018-09-26 11:57 ` [PATCH 1/2] dt-bindings: i2c-omap: Add new compatible " Vignesh R
2018-09-26 14:44 ` Peter Rosin
2018-09-28 5:27 ` Vignesh R [this message]
2018-09-26 11:57 ` [PATCH 2/2] i2c: busses: Kconfig: Enable I2C_OMAP for ARCH_K3 Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3943f2b1-3850-ad1e-6318-cfaec0eff485@ti.com \
--to=vigneshr@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox