From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dhowells@redhat.com, Alan Cox <alan@lxorguk.ukuu.org.uk>,
akpm@linux-foundation.org, gregkh@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not used
Date: Tue, 29 Sep 2009 16:55:45 +0100 [thread overview]
Message-ID: <395.1254239745@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.01.0909280743310.3349@localhost.localdomain>
Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> pty_slave_driver->owner = THIS_MODULE;
> pty_slave_driver->driver_name = "pty_slave";
> @@ -399,7 +387,7 @@ static void __init legacy_pty_init(void)
> pty_slave_driver->flags = TTY_DRIVER_RESET_TERMIOS |
> TTY_DRIVER_REAL_RAW;
> pty_slave_driver->other = pty_driver;
> - tty_set_operations(pty_slave_driver, &pty_ops);
> + tty_set_operations(pty_slave_driver, &pty_ops_bsd);
>
> if (tty_register_driver(pty_driver))
> panic("Couldn't register pty driver");
>
Is it right to use pty_ops_bsd in _both_ places? Looking at the code in
linux-2.6.0, the BSD ioctl only applies to the master and doesn't apply to the
slave.
David
next prev parent reply other threads:[~2009-09-29 15:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 13:53 [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not used David Howells
2009-09-28 14:16 ` Alan Cox
2009-09-28 14:55 ` David Howells
2009-09-28 15:25 ` Alan Cox
2009-09-28 14:55 ` Linus Torvalds
2009-09-29 15:55 ` David Howells [this message]
2009-09-29 16:23 ` Linus Torvalds
2009-09-29 16:38 ` Linus Torvalds
2009-09-29 18:40 ` David Howells
2009-09-29 22:39 ` Alan Cox
2009-09-30 10:20 ` David Howells
2009-09-30 11:28 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=395.1254239745@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox