From: Andre Werner <andre.werner@systec-electronic.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Andre Werner <andre.werner@systec-electronic.com>,
hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux@armlinux.org.uk,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next v5 1/2] net: phy: phy_device: Prevent nullptr exceptions on ISR
Date: Tue, 30 Jan 2024 07:54:04 +0100 (CET) [thread overview]
Message-ID: <395188fe-e73d-36c2-d36a-bc043744895f@systec-electronic.com> (raw)
In-Reply-To: <b507e17b-da8b-4616-b0d0-af9995bf8fc7@lunn.ch>
Thanks Andrew,
I will keep this in mind. Sorry!
Andre
On Mon, 29 Jan 2024, Andrew Lunn wrote:
> On Mon, Jan 29, 2024 at 02:55:04PM +0100, Andre Werner wrote:
>> If phydev->irq is set unconditionally, check
>> for valid interrupt handler or fall back to polling mode to prevent
>> nullptr exceptions in interrupt service routine.
>>
>> Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
>> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> Nitpick:
>
> Your Signed-off-by: should go last.
>
> Its not enough to need a respin, but please keep this in mind for
> future patches.
>
> Andrew
>
next prev parent reply other threads:[~2024-01-30 6:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 13:55 [net-next v5 0/2] Prevent nullptr exceptions in ISR Andre Werner
2024-01-29 13:55 ` [net-next v5 1/2] net: phy: phy_device: Prevent nullptr exceptions on ISR Andre Werner
2024-01-29 14:29 ` Andrew Lunn
2024-01-30 6:54 ` Andre Werner [this message]
2024-01-29 13:55 ` [net-next v5 2/2] net: phy: adin1100: Add interrupt support for link change Andre Werner
2024-02-01 0:30 ` [net-next v5 0/2] Prevent nullptr exceptions in ISR patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=395188fe-e73d-36c2-d36a-bc043744895f@systec-electronic.com \
--to=andre.werner@systec-electronic.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox