public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: linux-kernel@vger.kernel.org
Cc: Andy Lutomirski <luto@amacapital.net>,
	Ingo Molnar <mingo@elte.hu>,
	richard -rw- weinberger <richard.weinberger@gmail.com>,
	"H. Peter Anvin" <hpa@linux.intel.com>
Subject: x86-64: Make uaccess_err unsigned
Date: Tue, 10 Jan 2012 17:03:30 +0000	[thread overview]
Message-ID: <3955556.vbKFqerH5U@asus> (raw)

In commit 4fc3490114bb159bd4fff1b3c96f4320fe6fb08f uaccess_err
was changed from an int into a one bit bitfield. The values that
can be represented by a one bit bitfield are 0 and -1. Since
only values 0 and 1 are ever assigned to uaccess_err, make that
bitfield unsigned. Also change the one bit bitfield sig_on_uaccess
from signed into unsigned. This patch makes two annoying sparse
warnings about signed one bit bitfields disappear.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: richard -rw- weinberger <richard.weinberger@gmail.com>
Cc: H. Peter Anvin <hpa@linux.intel.com>
---
 arch/x86/include/asm/thread_info.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
index 7404715..ea3b445 100644
--- a/arch/x86/include/asm/thread_info.h
+++ b/arch/x86/include/asm/thread_info.h
@@ -40,8 +40,8 @@ struct thread_info {
 						*/
 	__u8			supervisor_stack[0];
 #endif
-	int			sig_on_uaccess_error:1;
-	int			uaccess_err:1;	/* uaccess failed */
+	unsigned		sig_on_uaccess_error:1;
+	unsigned		uaccess_err:1;	/* uaccess failed */
 };
 
 #define INIT_THREAD_INFO(tsk)			\
-- 
1.7.7



                 reply	other threads:[~2012-01-10 17:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3955556.vbKFqerH5U@asus \
    --to=bvanassche@acm.org \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@elte.hu \
    --cc=richard.weinberger@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox