From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754914AbbCMLYl (ORCPT ); Fri, 13 Mar 2015 07:24:41 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:57903 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751558AbbCMLYj (ORCPT ); Fri, 13 Mar 2015 07:24:39 -0400 From: Arnd Bergmann To: John Stultz Cc: lkml , Oded Gabbay , David Airlie , dri-devel@lists.freedesktop.org Subject: Re: [RFC][PATCH] amdkfd: Convert timestamping to use 64bit time accessors Date: Fri, 13 Mar 2015 12:24:27 +0100 Message-ID: <3959463.EVBM1FXcuD@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1426181020-2344-1-git-send-email-john.stultz@linaro.org> References: <1426181020-2344-1-git-send-email-john.stultz@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:aCGRlvERaNLUNxtoDaxjTAdQrwrfccnsdoS7ZZ3nCVNDx0t7EBH uCtvUEaobGeU0IVrEepnflnms8KYkwE8sIrKA70wY635ZUSOA622APSKdzflanxwn2ddi71 E6vw1SybPyb6igGtiMclVzZ+SjsSSJLZpoaFR9rZLjPjkMiBgVPEkpjwWbr02d8rQkKaJeB Ag4gMTR6UqSot6Wt7B7ug== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 12 March 2015 10:23:40 John Stultz wrote: > Convert the timestamping in the amdkfd driver to use > a timespec64 and 64bit time accessors. > > Cc: Arnd Bergmann > Cc: Oded Gabbay > Cc: David Airlie > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: John Stultz > The patch looks good, but I'd always include at least a one-liner about what it's good for. In this case, the existing code is completely safe beyond y2038 because you are dealing with monotonic time, so it's worth mentioning that we do this in order to kill off all uses of struct timespec. Arnd