From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753303AbcEWJ2p (ORCPT ); Mon, 23 May 2016 05:28:45 -0400 Received: from gloria.sntech.de ([95.129.55.99]:41340 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbcEWJ2o (ORCPT ); Mon, 23 May 2016 05:28:44 -0400 From: Heiko Stuebner To: Shunqian Zheng Cc: joro@8bytes.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Simon Subject: Re: [PATCH 1/5] iommu/rockchip: fix devm_request_irq and devm_free_irq parameter Date: Mon, 23 May 2016 11:28:32 +0200 Message-ID: <3963127.FSql0rTeZT@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1463967439-13354-2-git-send-email-zhengsq@rock-chips.com> References: <1463967439-13354-1-git-send-email-zhengsq@rock-chips.com> <1463967439-13354-2-git-send-email-zhengsq@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, 23. Mai 2016, 09:37:15 schrieb Shunqian Zheng: > From: Simon generally a "firstname surename " is expected, so a first name is not really enough. > > When rk_iommu_attach_device or rk_iommu_detach_device be called, the > second parameter "dev" represent the device who own the iommu, so it is > not resonable using "dev" for devm_request_irq's first parameter. To > avoid potential error, we must use iommu device itself "iommu->dev" > instead, the same as devm_free_irq. > > Signed-off-by: Simon same here, and the person sending in the patch also needs a signed-off-by line, so that should look like Signed-off-by: Simon Signed-off-by: Shunqian Zheng The same applies of course for all other affected patches of this series. After looking at the iommu code, I think the change itself looks sane, so Reviewed-by: Heiko Stuebner although I wonder what we need the devm_* for if we request and free the irqs manually all the time anyway? Heiko > --- > drivers/iommu/rockchip-iommu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iommu/rockchip-iommu.c > b/drivers/iommu/rockchip-iommu.c index c7d6156..ec0ce62 100644 > --- a/drivers/iommu/rockchip-iommu.c > +++ b/drivers/iommu/rockchip-iommu.c > @@ -807,7 +807,7 @@ static int rk_iommu_attach_device(struct iommu_domain > *domain, > > iommu->domain = domain; > > - ret = devm_request_irq(dev, iommu->irq, rk_iommu_irq, > + ret = devm_request_irq(iommu->dev, iommu->irq, rk_iommu_irq, > IRQF_SHARED, dev_name(dev), iommu); > if (ret) > return ret; > @@ -860,7 +860,7 @@ static void rk_iommu_detach_device(struct iommu_domain > *domain, } > rk_iommu_disable_stall(iommu); > > - devm_free_irq(dev, iommu->irq, iommu); > + devm_free_irq(iommu->dev, iommu->irq, iommu); > > iommu->domain = NULL;