From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755484AbdDRK7C (ORCPT <rfc822;w@1wt.eu>);
        Tue, 18 Apr 2017 06:59:02 -0400
Received: from mailout3.samsung.com ([203.254.224.33]:47762 "EHLO
        mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754919AbdDRK6h (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Apr 2017 06:58:37 -0400
X-AuditID: b6c32a35-f79806d000002bf4-cf-58f5f15a7b62
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        "James E.J. Bottomley" <jejb@parisc-linux.org>,
        Helge Deller <deller@gmx.de>, John David Anglin <dave.anglin@bell.net>,
        linux-parisc@vger.kernel.org
Subject: Re: [PATCH] ide: don't call memcpy with the same source and destination
Date: Tue, 18 Apr 2017 12:58:27 +0200
Message-id: <3967489.2j6es1sVNT@amdc3058>
User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <alpine.LRH.2.02.1704141433280.10706@file01.intranet.prod.int.rdu2.redhat.com>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset=us-ascii
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsWy7bCmrm70x68RBk90LLZveMpiMed8C4vF
        /U+3GS3ur1vFanFsxyMmi8u75rBZPDp1gcliYsdVJgcOj2WTP7J6bFl5k8njw8c4jwuLfrN6
        vN93lc3j8ya5ALYoLpuU1JzMstQifbsErowPc96xFdxkrbg/9wZzA+Mjli5GTg4JAROJfW+/
        s0LYYhIX7q1n62Lk4hAS2MEoseF4IyuE084kseZyJxtMx6rdbSwQiTmMEisPbWQGSQgJfGWU
        mNRVCGKzCVhJTGxfxQhiiwhoSlya8wZsErNAA5PE+2XTwBLCAkES9w5vAEpwcLAIqEoc3lME
        EuYFqr+xeRvYSaICXhJb9rUzgdicArES8070M0PUCEr8mHwP7AVmAXmJffunskLYOhJnj61j
        BNklIbCNXWL93etg8yUEZCU2HWCGeMBF4uPXPqj3hSVeHd/CDmFLS6z6d4sJwp7OKLH9twTE
        nM2MQB9PgCqyljh8/CLUMj6Jd197oObzSnS0CUGUeEhcuvoeKuwo8eAoJySs1jFKTDm2k20C
        o/wsJC/MQvLCLCQvLGBkXsUollpQnJueWmxYYKhXnJhbXJqXrpecn7uJEZxitEx3ME4553OI
        UYCDUYmHd8W+LxFCrIllxZW5hxglOJiVRHjXffgaIcSbklhZlVqUH19UmpNafIhRmoNFSZxX
        dP21CCGB9MSS1OzU1ILUIpgsEwenVAPjhAO3a1ZqZaosmX5g2dmOXzfXRHyy/lEUbNn7bqmO
        FSPTJeGnbMsND65ZoeIc5yLmt7Zgo8lxs4kvb/1TfzqBWfpTAiu/vPuLLPGlgtwH03rniW9x
        SPp4Y92TgnRP3qt8Plp6ClvuNwQxe2lyvTk3z7ht2ZGrsxtc1k60OjJjw5lso61eegZ/lViK
        MxINtZiLihMB+A0HHi0DAAA=
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsVy+t9jQd2oj18jDL4s1rXYvuEpi8Wc8y0s
        Fvc/3Wa0uL9uFavFsR2PmCwu75rDZvHo1AUmi4kdV5kcODyWTf7I6rFl5U0mjw8f4zwuLPrN
        6vF+31U2j8+b5ALYotxsMlITU1KLFFLzkvNTMvPSbZVCQ9x0LZQU8hJzU22VInR9Q4KUFMoS
        c0qBPCMDNODgHOAerKRvl+CW8WHOO7aCm6wV9+feYG5gfMTSxcjJISFgIrFqdxuULSZx4d56
        ti5GLg4hgVmMEk2bzjFDOF8ZJb7uXAFWxSZgJTGxfRUjiC0ioClxac4bVpAiZoEGJok9jcuY
        QBLCAgESWztOA3VzcLAIqEoc3lMEEuYFqr+xeRsriC0q4CWxZV87WDmnQKzE484NYPOFBGIk
        rjYfZYKoF5T4MfkeWJxZQF5i3/6prBC2lsT6nceZJjACnYlQNgtJ2SwkZQsYmVcxSqQWJBcU
        J6XnGuallusVJ+YWl+al6yXn525iBMfdM6kdjAd3uR9iFOBgVOLhXbHvS4QQa2JZcWXuIUYJ
        DmYlEd57d79GCPGmJFZWpRblxxeV5qQWH2I0BfpvIrOUaHI+MCXklcQbmpibmBsbWJhbWpoY
        KYnzNs5+Fi4kkJ5YkpqdmlqQWgTTx8TBKdXAmPE0q8je5ffha69nKRUl+bhIqX+UWNDBNi0w
        dKOqFUNgjvM3uwq53XNz1x1xMbverWj58/LHzj8tUrFzo0/qlf98l/Lx/4uzGz+/FuT5PHPG
        8TQblZCcuWp7hKtu8xwx2GHplOux22nhtLamnk+LM68/3vnz71G3tEcpV1nZ5lZdv37hYv+W
        40osxRmJhlrMRcWJAP8UwjLRAgAA
X-MTR: 20000000000000000@CPGS
X-CMS-MailID: 20170418105834epcas1p1b000622da41db1214d1a9a1b888f7896
X-Msg-Generator: CA
X-Sender-IP: 203.254.230.26
X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?=
        =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?=
X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?=
        =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?=
        =?UTF-8?B?bmdpbmVlcg==?=
X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?=
CMS-TYPE: 101P
X-HopCount: 7
X-CMS-RootMailID: 20170418105834epcas1p1b000622da41db1214d1a9a1b888f7896
X-RootMTR: 20170418105834epcas1p1b000622da41db1214d1a9a1b888f7896
References: <alpine.LRH.2.02.1704141433280.10706@file01.intranet.prod.int.rdu2.redhat.com>
 <CGME20170418105834epcas1p1b000622da41db1214d1a9a1b888f7896@epcas1p1.samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Friday, April 14, 2017 02:35:33 PM Mikulas Patocka wrote:
> The parisc architecture recently reimplemented the memcpy function and
> their reimplementation crashed when source and destination overlapped.
> 
> The crash happened in the function ide_complete_cmd where memcpy is called
> with the same source and destination pointer. According to the C
> specification, memcpy behavior is undefined if the source and destination
> range overlaps. This patches fixes the undefined behavior.
> 
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics