From: Markus Elfring <Markus.Elfring@web.de>
To: Liyuan Pang <pangliyuan1@huawei.com>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
wanqian10@huawei.com, Yang Liu <young.liuyang@huawei.com>,
Zhihao Cheng <chengzhihao1@huawei.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ubi: fastmap: fix ubi->fm memory leak
Date: Fri, 7 Nov 2025 08:00:51 +0100 [thread overview]
Message-ID: <396b2d11-29ca-4fae-97c3-7280c879cbfd@web.de> (raw)
In-Reply-To: <20251107021137.874150-1-pangliyuan1@huawei.com>
>> …
>>> +++ b/drivers/mtd/ubi/fastmap.c
>>> @@ -1644,3 +1644,15 @@ int ubi_update_fastmap(struct ubi_device *ubi)
>> …
>>> +void ubi_free_fastmap(struct ubi_device *ubi)
>>> +{
>>> + int i;
>>> +
>>> + if (ubi->fm) {
>> + for (i = 0; i < ubi->fm->used_blocks; i++)
>> + kmem_cache_free(ubi_wl_entry_slab, ubi->fm->e[i]);
>> …
>> + }
>> +}
>> …
>>
>> May the local variable “i” be defined in the loop header?
>
> I think it's better to leave it as it is, most of the code in
> ubi defines variables outside the loop header, and defining
> "i" in the loop header may cause compilation error in some old
> kernel versions that use C89.
Would you support to reduce the scope for such a variable to
the code block of the if branch?
Regards,
Markus
next prev parent reply other threads:[~2025-11-07 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 12:07 [PATCH] ubi: fastmap: fix ubi->fm memory leak Liyuan Pang
2025-11-06 15:16 ` Markus Elfring
2025-11-07 2:11 ` Liyuan Pang
2025-11-07 7:00 ` Markus Elfring [this message]
2025-11-07 9:38 ` Liyuan Pang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=396b2d11-29ca-4fae-97c3-7280c879cbfd@web.de \
--to=markus.elfring@web.de \
--cc=alexandre.torgue@foss.st.com \
--cc=chengzhihao1@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=pangliyuan1@huawei.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=wanqian10@huawei.com \
--cc=young.liuyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox