public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: 2.6.6-mm2
Date: Thu, 13 May 2004 12:14:57 -0700	[thread overview]
Message-ID: <39780000.1084475697@flay> (raw)

2.6.6-mm2 won't compile without CONFIG_MODULE_UNLOAD ... looks very much
like the first definition of add_attribute needs moving inside the ifdef.

kernel/module.c:730: redefinition of `add_attribute'
kernel/module.c:382: `add_attribute' previously defined here
{standard input}: Assembler messages:
{standard input}:1121: Error: symbol `add_attribute' is already defined

# grep MODULE .config
CONFIG_MODULES=y
# CONFIG_MODULE_UNLOAD is not set

--- 2.6.6-mm2/kernel/module.c.old	2004-05-13 11:08:39.000000000 -0700
+++ 2.6.6-mm2/kernel/module.c	2004-05-13 11:13:50.000000000 -0700
@@ -378,6 +378,7 @@
 }
 #endif /* CONFIG_SMP */
 
+#ifdef CONFIG_MODULE_UNLOAD
 static int add_attribute(struct module *mod, struct kernel_param *kp)
 {
 	struct module_attribute *a;
@@ -394,7 +395,6 @@
 	return retval;
 }
 
-#ifdef CONFIG_MODULE_UNLOAD
 /* Init the unload section of the module. */
 static void module_unload_init(struct module *mod)
 {


             reply	other threads:[~2004-05-13 19:17 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-13 19:14 Martin J. Bligh [this message]
2004-05-13 19:21 ` 2.6.6-mm2 Andrew Morton
2004-05-13 20:47 ` 2.6.6-mm2 Adrian Bunk
  -- strict thread matches above, loose matches on Subject: below --
2004-05-14 18:51 2.6.6-mm2 Jan Killius
     [not found] <fa.h4eq5gb.nj6q31@ifi.uio.no>
     [not found] ` <fa.gi5j8pu.92umbq@ifi.uio.no>
2004-05-14  0:50   ` 2.6.6-mm2 Andy Lutomirski
2004-05-14  1:01     ` 2.6.6-mm2 Chris Wright
2004-05-13 15:44 2.6.6-mm2 David Brownell
2004-05-13 12:39 2.6.6-mm2 Oleg Nesterov
2004-05-13 18:28 ` 2.6.6-mm2 Andrew Morton
2004-05-13 23:51 ` 2.6.6-mm2 Nick Piggin
2004-05-13 10:27 2.6.6-mm2 Andrew Morton
2004-05-13 10:45 ` 2.6.6-mm2 Christoph Hellwig
2004-05-13 10:51   ` 2.6.6-mm2 Andrew Morton
2004-05-13 11:12     ` 2.6.6-mm2 Christoph Hellwig
2004-05-13 11:25       ` 2.6.6-mm2 Andrew Morton
2004-05-13 13:18         ` 2.6.6-mm2 Adrian Bunk
2004-05-13 13:39           ` 2.6.6-mm2 Chris Mason
2004-05-13 14:09             ` 2.6.6-mm2 Adrian Bunk
2004-05-17 20:52               ` 2.6.6-mm2 Bill Davidsen
2004-05-14  7:30       ` 2.6.6-mm2 Ian Kent
2004-05-13 14:15     ` 2.6.6-mm2 Adrian Bunk
2004-05-13 19:18     ` 2.6.6-mm2 Chris Wright
2004-05-13 19:29       ` 2.6.6-mm2 Andrew Morton
2004-05-13 19:35         ` 2.6.6-mm2 Chris Wright
2004-05-13 19:38       ` 2.6.6-mm2 Andrew Morton
2004-05-13 19:42         ` 2.6.6-mm2 Chris Wright
2004-05-14 19:14           ` 2.6.6-mm2 Andrea Arcangeli
2004-05-14 20:58             ` 2.6.6-mm2 Chris Wright
2004-05-15  2:43               ` 2.6.6-mm2 Andrea Arcangeli
2004-05-15  7:43                 ` 2.6.6-mm2 Hugh Dickins
2004-05-14 19:06         ` 2.6.6-mm2 Kevin O'Connor
2004-05-14 19:36           ` 2.6.6-mm2 Chris Wright
2004-05-14 19:42           ` 2.6.6-mm2 Kevin O'Connor
2004-05-13 12:14 ` 2.6.6-mm2 Matt H.
2004-05-13 18:24   ` 2.6.6-mm2 Andrew Morton
2004-05-13 22:40     ` 2.6.6-mm2 Greg KH
2004-05-13 13:42 ` 2.6.6-mm2 Paolo Ornati
2004-05-13 15:07 ` 2.6.6-mm2 Lorenzo Allegrucci
2004-05-13 18:55   ` 2.6.6-mm2 Andrew Morton
2004-05-13 19:41     ` 2.6.6-mm2 Lorenzo Allegrucci
2004-05-14 17:48 ` 2.6.6-mm2 R. J. Wysocki
2004-05-14 17:47   ` 2.6.6-mm2 Christoph Hellwig
2004-05-14 21:20     ` 2.6.6-mm2 R. J. Wysocki
2004-05-14 23:56 ` 2.6.6-mm2 Joseph Fannin
2004-05-14 23:58   ` 2.6.6-mm2 Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39780000.1084475697@flay \
    --to=mbligh@aracnet.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox