From: John Garry <john.garry@huawei.com>
To: Rob Herring <robh@kernel.org>
Cc: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>,
<devicetree@vger.kernel.org>, <mark.rutland@arm.com>,
<linuxarm@huawei.com>, <zhangfei.gao@linaro.org>,
<xuwei5@hisilicon.com>, <john.garry2@mail.dcu.ie>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hare@suse.com>, Xiang Chen <chenxiang66@hisilicon.com>
Subject: Re: [PATCH 1/3] devicetree: bindings: scsi: hisi_sas hip07 support
Date: Sat, 24 Sep 2016 19:51:17 +0100 [thread overview]
Message-ID: <397f3957-ed99-d7e9-b808-a299d442b7dd@huawei.com> (raw)
In-Reply-To: <20160923183641.GA27636@rob-hp-laptop>
On 23/09/2016 19:36, Rob Herring wrote:
> On Tue, Sep 20, 2016 at 06:48:58PM +0800, John Garry wrote:
>> Add support for hip07 chipset to bindings.
>>
>> Chipset hip07 has v2 hw.
>>
>> The sas-v2 quirk amt is expanded to cover hip07.
>>
>> Signed-off-by: John Garry <john.garry@huawei.com>
>> Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
>> ---
>> Documentation/devicetree/bindings/scsi/hisilicon-sas.txt | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt b/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
>> index bf2411f..e604527 100644
>> --- a/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
>> +++ b/Documentation/devicetree/bindings/scsi/hisilicon-sas.txt
>> @@ -6,6 +6,7 @@ Main node required properties:
>> - compatible : value should be as follows:
>> (a) "hisilicon,hip05-sas-v1" for v1 hw in hip05 chipset
>> (b) "hisilicon,hip06-sas-v2" for v2 hw in hip06 chipset
>> + (c) "hisilicon,hip07-sas-v2" for v2 hw in hip07 chipset
>> - sas-addr : array of 8 bytes for host SAS address
>> - reg : Address and length of the SAS register
>> - hisilicon,sas-syscon: phandle of syscon used for sas control
>> @@ -47,7 +48,7 @@ Main node required properties:
>> increasing order.
>>
>> Optional main node properties:
>> - - hip06-sas-v2-quirk-amt : when set, indicates that the v2 controller has the
>> + - hip06/7-sas-v2-quirk-amt : when set, indicates that the v2 controller has the
>
> Just use the existing property name for hip07.
OK, but you mean existing hip06 property (hip06-sas-v2-quirk-amt), right?
>
>> "am-max-transmissions" limitation.
>>
>> Example:
>> --
>> 1.9.1
>>
>
> .
>
next prev parent reply other threads:[~2016-09-24 18:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 10:48 [PATCH 0/3] hisi_sas add hip07 support John Garry
2016-09-20 10:48 ` [PATCH 1/3] devicetree: bindings: scsi: hisi_sas " John Garry
2016-09-23 18:36 ` Rob Herring
2016-09-24 18:51 ` John Garry [this message]
2016-09-20 10:48 ` [PATCH 2/3] hisi_sas: add device tree support for hip07 John Garry
2016-09-20 10:49 ` [PATCH 3/3] hisi_sas: add v2 hw support for different refclk John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=397f3957-ed99-d7e9-b808-a299d442b7dd@huawei.com \
--to=john.garry@huawei.com \
--cc=chenxiang66@hisilicon.com \
--cc=devicetree@vger.kernel.org \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry2@mail.dcu.ie \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=martin.petersen@oracle.com \
--cc=robh@kernel.org \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox