public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Michael Rubin <mrubin@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 10/11] writeback: remove redirty_tail()
Date: Fri, 28 Dec 2007 21:41:29 +0800	[thread overview]
Message-ID: <398849895.70302@ustc.edu.cn> (raw)
Message-ID: <20071228135123.092384048@mail.ustc.edu.cn> (raw)
In-Reply-To: 20071228134119.112899193@mail.ustc.edu.cn

[-- Attachment #1: writeback-remove-redirty_tail.patch --]
[-- Type: text/plain, Size: 1490 bytes --]

Remove redirty_tail(). It's no longer used.

Cc: Michael Rubin <mrubin@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
 fs/fs-writeback.c |   24 ------------------------
 1 file changed, 24 deletions(-)

--- linux-2.6.24-rc6-mm1.orig/fs/fs-writeback.c
+++ linux-2.6.24-rc6-mm1/fs/fs-writeback.c
@@ -146,34 +146,10 @@ static int write_inode(struct inode *ino
 		return inode->i_sb->s_op->write_inode(inode, sync);
 	return 0;
 }
 
 /*
- * Redirty an inode: set its when-it-was dirtied timestamp and move it to the
- * furthest end of its superblock's dirty-inode list.
- *
- * Before stamping the inode's ->dirtied_when, we check to see whether it is
- * already the most-recently-dirtied inode on the s_dirty list.  If that is
- * the case then the inode must have been redirtied while it was being written
- * out and we don't reset its dirtied_when.
- */
-static void redirty_tail(struct inode *inode)
-{
-	struct super_block *sb = inode->i_sb;
-
-	if (!list_empty(&sb->s_dirty)) {
-		struct inode *tail_inode;
-
-		tail_inode = list_entry(sb->s_dirty.next, struct inode, i_list);
-		if (!time_after_eq(inode->dirtied_when,
-				tail_inode->dirtied_when))
-			inode->dirtied_when = jiffies;
-	}
-	list_move(&inode->i_list, &sb->s_dirty);
-}
-
-/*
  * requeue inode for re-scanning after sb->s_io list is exhausted.
  */
 static void requeue_io(struct inode *inode)
 {
 	list_move(&inode->i_list, &inode->i_sb->s_more_io);

-- 

  parent reply	other threads:[~2007-12-28 13:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071228134119.112899193@mail.ustc.edu.cn>
2007-12-28 13:41 ` [PATCH 00/11] writeback bug fixes and simplifications Fengguang Wu
     [not found] ` <20071228135121.729972858@mail.ustc.edu.cn>
2007-12-28 13:41   ` [PATCH 01/11] writeback: introduce s_more_io_wait for inodes to be re-synced after a while Fengguang Wu
     [not found] ` <20071228135121.907366463@mail.ustc.edu.cn>
2007-12-28 13:41   ` [PATCH 02/11] writeback: requeue_io_wait() on blocked kupdate Fengguang Wu
     [not found] ` <20071228135122.055004293@mail.ustc.edu.cn>
2007-12-28 13:41   ` [PATCH 03/11] writeback: replace redirty_tail() on more-pages-to-sync Fengguang Wu
     [not found] ` <20071228135122.207057056@mail.ustc.edu.cn>
2007-12-28 13:41   ` [PATCH 04/11] writeback: requeue_io_wait() on locked inode Fengguang Wu
     [not found] ` <20071228135122.352597180@mail.ustc.edu.cn>
2007-12-28 13:41   ` [PATCH 05/11] writeback: requeue_io_wait() on congested blockdev Fengguang Wu
     [not found] ` <20071228135122.498901458@mail.ustc.edu.cn>
2007-12-28 13:41   ` [PATCH 06/11] writeback: requeue_io_wait() on locked buffers Fengguang Wu
     [not found] ` <20071228135122.639594456@mail.ustc.edu.cn>
2007-12-28 13:41   ` [PATCH 07/11] writeback: requeue_io() on redirtied inode Fengguang Wu
     [not found] ` <20071228135122.779152029@mail.ustc.edu.cn>
2007-12-28 13:41   ` [PATCH 08/11] writeback: introduce queue_dirty() Fengguang Wu
     [not found] ` <20071228135122.931500020@mail.ustc.edu.cn>
2007-12-28 13:41   ` [PATCH 09/11] writeback: replace redirty_tail() on memory-backed bdi Fengguang Wu
     [not found] ` <20071228135123.092384048@mail.ustc.edu.cn>
2007-12-28 13:41   ` Fengguang Wu [this message]
     [not found] ` <20071228135123.237186756@mail.ustc.edu.cn>
2007-12-28 13:41   ` [PATCH 11/11] writeback: __sync_single_inode() code cleanup Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=398849895.70302@ustc.edu.cn \
    --to=wfg@mail.ustc.edu.cn \
    --cc=akpm@osdl.org \
    --cc=mrubin@google.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox