Re: [PATCH V2 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

kgunda
2018-05-08T10:04:24Z

On 2018-05-07 22:15, Rob Herring wrote:
> On Thu, May 03, 2018 at 03:42:29PM +0530, Kiran Gunda wrote:
>> WLED4 peripheral is present on some PMICs like pmi8998
>> and pm660l. It has a different register map and also
>> configurations are different. Add support for it.
>>
>> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org>
>> ---
>> .../bindings/leds/backlight/qcom-wled.txt | 172 ++++-
>
> Please split bindings to a separate patch.
>
> This is also a whole lot of churn re-formatting. That is fine, but
> don't
> mix actual changes to the binding with re-formatting. You can do 2
> patches in this case:
>
> - move and reformat (as long as the move shows up as a move
> and not a remove and add)
> - additions for new chips
>
Sure. I will do it in the next series.
>> drivers/video/backlight/qcom-wled.c | 749
>> +++++++++++++++------
>> 2 files changed, 696 insertions(+), 225 deletions(-)