From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xen.org
Cc: linux-kernel@vger.kernel.org, jgross@suse.com,
Stefano Stabellini <stefano@aporeto.com>
Subject: Re: [PATCH v2 07/18] xen/pvcalls: implement socket command
Date: Fri, 26 May 2017 11:53:28 -0400 [thread overview]
Message-ID: <399535eb-ad9c-08f4-2fd7-bb44c0e11c0a@oracle.com> (raw)
In-Reply-To: <1495236179-27776-7-git-send-email-sstabellini@kernel.org>
> static int pvcalls_back_socket(struct xenbus_device *dev,
> struct xen_pvcalls_request *req)
> {
> - return 0;
> + struct pvcalls_back_priv *priv;
> + int ret;
> + struct xen_pvcalls_response *rsp;
> +
> + priv = dev_get_drvdata(&dev->dev);
> +
> + if (req->u.socket.domain != AF_INET ||
> + req->u.socket.type != SOCK_STREAM ||
> + (req->u.socket.protocol != 0 &&
> + req->u.socket.protocol != AF_INET))
Shouldn't this be one of IPPROTO_* macros?
-boris
next prev parent reply other threads:[~2017-05-26 15:54 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 23:17 [PATCH v2 00/18] introduce the Xen PV Calls backend Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 01/18] xen: introduce the pvcalls interface header Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 02/18] xen/pvcalls: introduce the pvcalls xenbus backend Stefano Stabellini
2017-05-25 22:04 ` Boris Ostrovsky
2017-05-19 23:22 ` [PATCH v2 03/18] xen/pvcalls: initialize the module and register the " Stefano Stabellini
2017-05-25 22:12 ` Boris Ostrovsky
2017-05-19 23:22 ` [PATCH v2 04/18] xen/pvcalls: xenbus state handling Stefano Stabellini
2017-05-26 0:12 ` Boris Ostrovsky
2017-06-01 20:54 ` Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 05/18] xen/pvcalls: connect to a frontend Stefano Stabellini
2017-05-26 15:23 ` Boris Ostrovsky
2017-06-01 21:06 ` Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 06/18] xen/pvcalls: handle commands from the frontend Stefano Stabellini
2017-05-26 15:32 ` Boris Ostrovsky
2017-06-02 18:21 ` Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 07/18] xen/pvcalls: implement socket command Stefano Stabellini
2017-05-26 15:53 ` Boris Ostrovsky [this message]
2017-06-02 18:35 ` Stefano Stabellini
2017-05-26 18:58 ` Boris Ostrovsky
2017-06-02 18:41 ` Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 08/18] xen/pvcalls: implement connect command Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 09/18] xen/pvcalls: implement bind command Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 10/18] xen/pvcalls: implement listen command Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 11/18] xen/pvcalls: implement accept command Stefano Stabellini
2017-05-26 18:18 ` Boris Ostrovsky
2017-06-02 19:19 ` Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 12/18] xen/pvcalls: implement poll command Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 13/18] xen/pvcalls: implement release command Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 14/18] xen/pvcalls: disconnect and module_exit Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 15/18] xen/pvcalls: implement the ioworker functions Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 16/18] xen/pvcalls: implement read Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 17/18] xen/pvcalls: implement write Stefano Stabellini
2017-05-19 23:22 ` [PATCH v2 18/18] xen: introduce a Kconfig option to enable the pvcalls backend Stefano Stabellini
2017-05-25 22:02 ` [PATCH v2 01/18] xen: introduce the pvcalls interface header Boris Ostrovsky
2017-06-01 20:54 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=399535eb-ad9c-08f4-2fd7-bb44c0e11c0a@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=stefano@aporeto.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).