From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Francois romieu <romieu@ensta.fr>
Cc: linux-kernel@vger.kernel.org, aprasad@in.ibm.com
Subject: Re: ioremap of pci base addresses
Date: Thu, 12 Oct 2000 11:11:30 -0400 [thread overview]
Message-ID: <39E5D4A2.E26836A9@mandrakesoft.com> (raw)
In-Reply-To: 20001012105200.A28642@nic.fr
Francois romieu wrote:
> token = (unsigned long)ioremap(pci_resource_start(pdev, 0),
> pci_resource_len(pdev, 0));
Looks great except for one small point -- we have been going through
drivers cleaning up where they start casting like this. You should this
token as a void*, and code which uses the value should adjust
accordingly...
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2000-10-12 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA256976.001F00B2.00@d73mta05.au.ibm.com>
2000-10-12 10:52 ` ioremap of pci base addresses Francois romieu
2000-10-12 15:11 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39E5D4A2.E26836A9@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=aprasad@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@ensta.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox