From: Andrew Morton <andrewm@uow.edu.au>
To: "Stephen E. Clark" <sclark46@gte.net>
Cc: lk <linux-kernel@vger.kernel.org>, "David S. Miller" <davem@redhat.com>
Subject: Re: RTNL assert
Date: Sat, 28 Oct 2000 21:52:34 +1100 [thread overview]
Message-ID: <39FAAFF2.200E1860@uow.edu.au> (raw)
In-Reply-To: <39FA4968.62588272@gte.net>
"Stephen E. Clark" wrote:
>
> When I configure in Tunneling I get the following error message. Is this
> normal? This with 2.4test9pre5
>
> GRE over IPv4 tunneling driver
> RTNL: assertion failed at devinet.c(775):inetdev_event
The rtnetlink lock needs to be taken around
register_netdevice(). There should be a function
which does these three common steps, but there isn't.
--- linux-2.4.0-test10-pre5/net/ipv4/ip_gre.c Sat Sep 9 16:19:30 2000
+++ linux-akpm/net/ipv4/ip_gre.c Sat Oct 28 21:44:23 2000
@@ -1266,7 +1266,9 @@
#ifdef MODULE
register_netdev(&ipgre_fb_tunnel_dev);
#else
+ rtnl_lock();
register_netdevice(&ipgre_fb_tunnel_dev);
+ rtnl_unlock();
#endif
inet_add_protocol(&ipgre_protocol);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-10-28 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-10-28 3:35 RTNL assert Stephen E. Clark
2000-10-28 10:52 ` Andrew Morton [this message]
2000-10-28 14:14 ` Stephen E. Clark
2000-10-28 16:18 ` Andrew Morton
2000-10-28 17:05 ` David S. Miller
2000-10-30 15:11 ` David Woodhouse
2000-10-30 16:43 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2000-10-28 3:33 Stephen E. Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39FAAFF2.200E1860@uow.edu.au \
--to=andrewm@uow.edu.au \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sclark46@gte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox