From: Brian Gerst <bgerst@didntduck.org>
To: Philipp Rumpf <prumpf@parcelfarce.linux.theplanet.co.uk>
Cc: Andrew Morton <andrewm@uow.edu.au>,
Patrick van de Lageweg <patrick@bitwizard.nl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rogier Wolff <wolff@bitwizard.nl>,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [PROPOSED PATCH] ATM refcount + firestream
Date: Sat, 28 Oct 2000 09:55:21 -0400 [thread overview]
Message-ID: <39FADAC9.DC1255D1@didntduck.org> (raw)
In-Reply-To: <Pine.LNX.4.21.0010270945510.13233-200000@panoramix.bitwizard.nl> <39F96BE1.B9C97C20@uow.edu.au> <20001028141518.A2272@parcelfarce.linux.theplanet.co.uk> <39FAD698.2FF9C8C8@didntduck.org> <20001028145312.B2272@parcelfarce.linux.theplanet.co.uk>
Philipp Rumpf wrote:
>
> On Sat, Oct 28, 2000 at 09:37:28AM -0400, Brian Gerst wrote:
> > Philipp Rumpf wrote:
> > > - you can't copy_(from|to)_user in the module exit function (which would
> > > be copies from/to rmmod anyway)
> >
> > Unfortunately, you need to be able to use copy_*_user() from the network
> > ioctls, and this is the center of the current issue.
>
> You misunderstood. The network ioctls aren't module_exit functions, so
> copy_*_user in them is fine.
Yes, but they can be called (and sleep) with module refcount == 0. This
is because the file descripter used to perform the ioctl isn't directly
associated with the network device, thereby not incrementing the
refcount on open.
--
Brian Gerst
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-10-28 14:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-10-27 7:50 [PROPOSED PATCH] ATM refcount + firestream Patrick van de Lageweg
2000-10-27 11:49 ` Andrew Morton
2000-10-27 13:49 ` Brian Gerst
2000-10-27 14:34 ` Patrick van de Lageweg
2000-10-27 14:49 ` Brian Gerst
2000-10-27 14:56 ` Rogier Wolff
2000-10-28 13:15 ` Philipp Rumpf
2000-10-28 13:37 ` Brian Gerst
2000-10-28 13:53 ` Philipp Rumpf
2000-10-28 13:55 ` Brian Gerst [this message]
2000-10-28 15:05 ` Philipp Rumpf
2000-10-28 15:50 ` Brian Gerst
2000-10-28 16:10 ` Andrew Morton
2000-10-30 15:18 ` Philipp Rumpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39FADAC9.DC1255D1@didntduck.org \
--to=bgerst@didntduck.org \
--cc=andrewm@uow.edu.au \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick@bitwizard.nl \
--cc=prumpf@parcelfarce.linux.theplanet.co.uk \
--cc=torvalds@transmeta.com \
--cc=wolff@bitwizard.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox