Re: RTNL assert

Andrew Morton
2000-10-28T10:53:13Z

"Stephen E. Clark" wrote:
>
> When I configure in Tunneling I get the following error message. Is this
> normal? This with 2.4test9pre5
>
> GRE over IPv4 tunneling driver
> RTNL: assertion failed at devinet.c(775):inetdev_event

The rtnetlink lock needs to be taken around
register_netdevice(). There should be a function
which does these three common steps, but there isn't.

--- linux-2.4.0-test10-pre5/net/ipv4/ip_gre.c Sat Sep 9 16:19:30 2000
+++ linux-akpm/net/ipv4/ip_gre.c Sat Oct 28 21:44:23 2000
@@ -1266,7 +1266,9 @@
#ifdef MODULE
register_netdev(&ipgre_fb_tunnel_dev);
#else
+ rtnl_lock();
register_netdevice(&ipgre_fb_tunnel_dev);
+ rtnl_unlock();
#endif

inet_add_protocol(&ipgre_protocol);