public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Rasmus Andersen <rasmus@jaquet.dk>
Cc: Arjan van de Ven <arjan@fenrus.demon.nl>,
	linux-kernel@vger.kernel.org, David Hinds <dhinds@valinux.com>,
	corey@world.std.com
Subject: Re: Compile error in drivers/ide/osb4.c in 240-t10p6
Date: Sun, 29 Oct 2000 20:09:16 -0500	[thread overview]
Message-ID: <39FCCA3C.27EDB2FF@mandrakesoft.com> (raw)
In-Reply-To: <20001029144822.B622@jaquet.dk> <m13psPR-000OXnC@amadeus.home.nl> <20001029231257.J625@jaquet.dk>

Rasmus Andersen wrote:
> Thanks for the pointer. However my test build still barfs in the final
> link phase because we (in t10p6) morphed drivers/pcmcia/cs.c::pcmcia_
> request_irq into (the static) cs_request_irq. The rename part
> broke the two other places in cs.c where pcmcia_request_irq was
> referenced and the static part made its usage in drivers/net/pcmcia/
> ray_cs.c a bit awkward.
> 
> Since I won't presume to question the decision to rename the function
> the following patch propagates the rename to the rest of the kernel.
> Furthermore, I presumed to remove the static part so that the ray_cs
> driver was free to use it. I have added David Hinds and Corey Thomas
> (the raylink driver maintainer) to the cc on this mail so they can
> decide what the proper solution is.

This is what went to Linus, and David Hinds ack'd it.

http://gtf.org/garzik/kernel/files/patches/2.4/2.4.0-test10/pcmcia-2.4.0.10.6.patch.gz

	Jeff



-- 
Jeff Garzik             | "Mind if I drive?"  -Sam
Building 1024           | "Not if you don't mind me clawing at the
MandrakeSoft            |  dash and shrieking like a cheerleader."
                        |                     -Max
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2000-10-30  1:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-10-29 13:48 Compile error in drivers/ide/osb4.c in 240-t10p6 Rasmus Andersen
2000-10-29 13:22 ` Arjan van de Ven
2000-10-29 22:12   ` Rasmus Andersen
2000-10-30  1:09     ` Jeff Garzik [this message]
2000-10-30  2:32     ` David Hinds
2000-10-30 10:40       ` coreythomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39FCCA3C.27EDB2FF@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=arjan@fenrus.demon.nl \
    --cc=corey@world.std.com \
    --cc=dhinds@valinux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rasmus@jaquet.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox