Re: Compile error in drivers/ide/osb4.c in 240-t10p6

coreythomas
2000-10-30T10:40:52Z

ray_cs was imported to the kernel as one of the first test drivers by
Linus. At the time, he wanted to get rid of the CardServices(function...)
interface and replace it with pcmcia_function calls. It seems that
the correct fix would be to change pcmcia_request_irq to RequestIRQ
like all the other drivers use. Or, change all the other drivers. In
any case I know of no reason for ray_cs to be unique.

David Hinds <dhinds@lahmed.Stanford.EDU> writes:

> On Sun, Oct 29, 2000 at 11:12:57PM +0100, Rasmus Andersen wrote:
> >
> > Thanks for the pointer. However my test build still barfs in the final
> > link phase because we (in t10p6) morphed drivers/pcmcia/cs.c::pcmcia_
> > request_irq into (the static) cs_request_irq. The rename part
> > broke the two other places in cs.c where pcmcia_request_irq was
> > referenced and the static part made its usage in drivers/net/pcmcia/
> > ray_cs.c a bit awkward.
>
> It should be un-morphed back to the way it was. It was an error that
> slipped into a patch I was preparing, because I was hand-editing the
> "diff" output to accommodate some changes between the kernel tree and
> the separate PCMCIA package.
>
> -- Dave