Re: 2.4.0-test10-pre6: Use of abs()

Theodore Y. Ts'o
2000-11-02T03:03:03Z

Date: Wed, 1 Nov 2000 09:46:19 -0500
From: tytso@MIT.EDU

On Mon, Oct 30, 2000 at 05:14:34PM +0100, Martin Dalecki wrote:
> Of corse right! BTW. There are tons of places where log2 is calculated
> explicitly in kernel which should be replaced with the corresponding
> built
> in functions as well (/dev/random code does it). And then If I remember
> correctly
> there is an attribute which is telling about internal functions
> in declarations explicitly as well?

And in the case of /dev/random, since we know something about what the
possible inputs can be, I'm fairly certain that the "int_ln_12bits" used
by /dev/random is probably far better than the general purpose code
which GCC no doubt has to emit....

- Ted