Re: [PATCH v2 1/3] dt-bindings: iio: light: ROHM BH1745

Krzysztof Kozlowski
2024-06-04T06:35:36Z

On 03/06/2024 18:21, Mudit Sharma wrote:
> Add ROHM BH1745 - 4 channel I2C colour sensor's dt-bindings.
>
> Signed-off-by: Mudit Sharma <muditsharma.info@gmail.com>
> ---
> v1->v2:
> - Fix yaml issue: Make `maintainers` a list

Judging by driver there will be v3, so few nits.

>
> .../bindings/iio/light/rohm,bh1745.yaml | 49 +++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/rohm,bh1745.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/light/rohm,bh1745.yaml b/Documentation/devicetree/bindings/iio/light/rohm,bh1745.yaml
> new file mode 100644
> index 000000000000..ac5c4d160513
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/rohm,bh1745.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/rohm,bh1745.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ROHM BH1745 colour sensor
> +
> +maintainers:
> + - Mudit Sharma <muditsharma.info@gmail.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> + BH1745 is an I2C colour sensor with red, green, blue and clear
> + channels. It has a programmable active low interrupt pin.
> + Interrupt occurs when the signal from the selected interrupt
> + source channel crosses set interrupt threshold high/low level.
> +
> +properties:
> + compatible:
> + const: rohm,bh1745
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> +additionalProperties: false

Please put this after required: block.

> +
> +required:
> + - compatible
> + - reg
> +

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Best regards,
Krzysztof