Re: [PATCH 1/2] dt-bindings: intel: Add Agilex3 SoCFPGA board

[Krzysztof Kozlowski <krzk@kernel.org>]

On 10/11/2025 13:36, Dinh Nguyen wrote:
> 
> 
> On 11/10/25 01:53, Krzysztof Kozlowski wrote:
>> On 10/11/2025 07:47, niravkumarlaxmidas.rabara@altera.com wrote:
>>> From: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>
>>>
>>> Add compatible for Agilex3 SoCFPGA board.
> 
>>>
>>> Signed-off-by: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>
>>> ---
>>>   Documentation/devicetree/bindings/arm/intel,socfpga.yaml | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/intel,socfpga.yaml b/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
>>> index cf7a91dfec8a..e706c4eff019 100644
>>> --- a/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
>>> @@ -21,6 +21,11 @@ properties:
>>>                 - intel,socfpga-agilex-n6000
>>>                 - intel,socfpga-agilex-socdk
>>>             - const: intel,socfpga-agilex
>>> +      - description: Agilex3 boards
>>
>> Agilex3?
>>
> 
>  From what I understand, the Agilex3 is the same chip as the Agilex5, 
> minus 2 CPU cores. So I recommended to Nirav, just to add the binding in 
> the Agilex5 context.

If that is not the same die, then probably should have still agilex3
compatible (you still can have fallback).

> 
>>> +        items:
>>> +          - enum:
>>> +              - intel,socfpga-agilex3-socdk
>>> +          - const: intel,socfpga-agilex5
>>
>> Or Agilex5? Decide. Cannot be both.
>>
>  From the explanation above, could we document the agilex3 socdk this way?
> 
> Thanks,
> Dinh


Best regards,
Krzysztof