From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3248C4332F for ; Thu, 14 Dec 2023 12:54:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573159AbjLNMyZ convert rfc822-to-8bit (ORCPT ); Thu, 14 Dec 2023 07:54:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1573145AbjLNMyX (ORCPT ); Thu, 14 Dec 2023 07:54:23 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52CE2113; Thu, 14 Dec 2023 04:54:30 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3BECsBVp9840430, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3BECsBVp9840430 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 14 Dec 2023 20:54:11 +0800 Received: from RTEXDAG01.realtek.com.tw (172.21.6.100) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 14 Dec 2023 20:54:12 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXDAG01.realtek.com.tw (172.21.6.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Thu, 14 Dec 2023 20:54:11 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7]) by RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7%5]) with mapi id 15.01.2375.007; Thu, 14 Dec 2023 20:54:11 +0800 From: JustinLai0215 To: Jakub Kicinski CC: "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "andrew@lunn.ch" , Ping-Ke Shih , Larry Chiu Subject: RE: [PATCH net-next v14 03/13] rtase: Implement the rtase_down function Thread-Topic: [PATCH net-next v14 03/13] rtase: Implement the rtase_down function Thread-Index: AQHaKbuZ68k3qmPPt0euso8G9Dk2ErCliPGAgAM8MgA= Date: Thu, 14 Dec 2023 12:54:11 +0000 Message-ID: <39c9b2df2a02412b84f6e7946f012917@realtek.com> References: <20231208094733.1671296-1-justinlai0215@realtek.com> <20231208094733.1671296-4-justinlai0215@realtek.com> <20231212112735.180d455f@kernel.org> In-Reply-To: <20231212112735.180d455f@kernel.org> Accept-Language: zh-TW, en-US Content-Language: zh-TW x-originating-ip: [172.21.210.185] x-kse-serverinfo: RTEXDAG01.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > On Fri, 8 Dec 2023 17:47:23 +0800 Justin Lai wrote: > > + netif_stop_queue(dev); > > You most likely want to stop the napi before you call this. > Otherwise NAPI can do some clean up and restart the queue. > > > + /* give a racing hard_start_xmit a few cycles to complete */ > > + synchronize_rcu(); > > Call netif_tx_disable() instead of stop_queue(), it takes the tx lock so you don't > have to worry about in-flight packets. Thanks for your suggestion, I will modify it. > > > + netif_carrier_off(dev); > > + > > + for (i = 0; i < tp->int_nums; i++) { > > + ivec = &tp->int_vector[i]; > > + synchronize_irq(ivec->irq); > > Why? This is redundant code, I will remove it. > > > + /* wait for any pending NAPI task to complete */ > > + napi_disable(&ivec->napi); > > + }