From: Stephen Boyd <sboyd@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Jesse Taube <mr.bossman075@gmail.com>,
linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, Yimin Gu <ustcymgu@gmail.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
Michael Turquette <mturquette@baylibre.com>,
Waldemar Brodkorb <wbx@openadk.org>,
Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Conor Dooley <conor.dooley@microchip.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v3 1/3] clk: k210: remove an implicit 64-bit division
Date: Mon, 06 Mar 2023 14:37:22 -0800 [thread overview]
Message-ID: <39d89928de4c52d10fd98bca61b549fa.sboyd@kernel.org> (raw)
In-Reply-To: <be589843-dfc1-47dc-a488-a4fad645c638@spud>
Quoting Conor Dooley (2023-03-06 14:35:01)
> On Mon, Mar 06, 2023 at 02:31:00PM -0800, Stephen Boyd wrote:
> > Quoting Jesse Taube (2023-02-28 16:26:55)
> > > diff --git a/drivers/clk/clk-k210.c b/drivers/clk/clk-k210.c
> > > index 67a7cb3503c3..4eed667eddaf 100644
> > > --- a/drivers/clk/clk-k210.c
> > > +++ b/drivers/clk/clk-k210.c
> > > @@ -495,7 +495,7 @@ static unsigned long k210_pll_get_rate(struct clk_hw *hw,
> > > f = FIELD_GET(K210_PLL_CLKF, reg) + 1;
> > > od = FIELD_GET(K210_PLL_CLKOD, reg) + 1;
> > >
> > > - return (u64)parent_rate * f / (r * od);
> > > + return div_u64((u64)parent_rate * f, r * od);
> >
> > The equation 'r * od' can't overflow 32-bits, right?
>
> Yah, I checked that when writing the patch. They're 4-bit fields:
Awesome
next prev parent reply other threads:[~2023-03-06 22:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 0:26 [PATCH v3 0/3] Add RISC-V 32 NOMMU support Jesse Taube
2023-03-01 0:26 ` [PATCH v3 1/3] clk: k210: remove an implicit 64-bit division Jesse Taube
2023-03-01 1:19 ` Damien Le Moal
2023-03-06 22:31 ` Stephen Boyd
2023-03-06 22:35 ` Conor Dooley
2023-03-06 22:37 ` Stephen Boyd [this message]
2023-03-06 22:41 ` Stephen Boyd
2023-03-06 22:48 ` Palmer Dabbelt
2023-03-01 0:26 ` [PATCH v3 2/3] riscv: Kconfig: Allow RV32 to build with no MMU Jesse Taube
2023-03-01 1:22 ` Damien Le Moal
2023-03-01 0:26 ` [PATCH v3 3/3] riscv: configs: Add nommu PHONY defconfig for RV32 Jesse Taube
2023-03-01 4:07 ` [PATCH v3 0/3] Add RISC-V 32 NOMMU support Randy Dunlap
2023-03-01 4:42 ` Damien Le Moal
2023-03-08 1:26 ` Jesse Taube
2023-03-08 2:16 ` Randy Dunlap
2023-03-08 2:30 ` Jesse Taube
2023-03-08 2:33 ` Randy Dunlap
2023-03-08 2:51 ` Randy Dunlap
2023-03-08 2:54 ` Jesse Taube
2023-03-08 3:23 ` Randy Dunlap
2023-03-08 3:42 ` Damien Le Moal
2023-03-08 3:46 ` Jesse Taube
2023-03-08 4:11 ` Damien Le Moal
2023-03-14 18:35 ` Jesse Taube
2023-03-14 19:16 ` Conor Dooley
2023-03-08 3:51 ` Randy Dunlap
2023-03-25 11:57 ` Conor Dooley
2023-03-28 18:50 ` (subset) " Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39d89928de4c52d10fd98bca61b549fa.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=damien.lemoal@wdc.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=mr.bossman075@gmail.com \
--cc=mturquette@baylibre.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=ustcymgu@gmail.com \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox