public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Josua Mayer <josua@solid-run.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
	Vincent Mailhol <mailhol@kernel.org>,
	Vinod Koul <vkoul@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Peter Rosin <peda@axentia.se>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Andreas Kemnade <andreas@kemnade.info>,
	Kevin Hilman <khilman@baylibre.com>,
	Roger Quadros <rogerq@kernel.org>,
	Tony Lindgren <tony@atomide.com>,
	Janusz Krzysztofik <jmkrzyszt@gmail.com>,
	Vignesh R <vigneshr@ti.com>, Andi Shyti <andi.shyti@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Yazan Shhady <yazan.shhady@solid-run.com>,
	Jon Nettleton <jon@solid-run.com>,
	Mikhail Anikin <mikhail.anikin@solid-run.com>,
	"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
	"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v8 3/7] mux: add help text for MULTIPLEXER config option
Date: Mon, 9 Feb 2026 10:12:17 +0000	[thread overview]
Message-ID: <39f3891c-c05a-4e10-9ad4-ab3cbc6fa70e@solid-run.com> (raw)
In-Reply-To: <CAMuHMdU01vwif4H6H-cYUfW0Y56fN6Anp9F4Ru7q3fveNqqoXA@mail.gmail.com>

On 09/02/2026 10:06, Geert Uytterhoeven wrote:
> Hi Josua,
>
> On Sun, 8 Feb 2026 at 16:16, Josua Mayer <josua@solid-run.com> wrote:
>> On 03/02/2026 15:01, Josua Mayer wrote:
>>> Add prompt and help text for CONFIG_MULTIPLEXER to allow enabling this
>>> option thorugh the kernel configuration without explicit "select" driver
>>> dependencies.
>>>
>>> Select it by default when COMPILE_TEST is set for better coverage.
>>>
>>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>>> ---
>>>    drivers/mux/Kconfig | 8 +++++++-
>>>    1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig
>>> index c68132e38138..e31c46820bdf 100644
>>> --- a/drivers/mux/Kconfig
>>> +++ b/drivers/mux/Kconfig
>>> @@ -4,7 +4,13 @@
>>>    #
>>>
>>>    config MULTIPLEXER
>>> -     tristate
>>> +     tristate "Generic Multiplexer Support" if COMPILE_TEST
>> This didn't do what I thought it would.
>> It was my intention to allow enabling this through menuconfig / .config.
>>
>> With the syntax above menuconfig shows:
>>
>> │ Symbol: MULTIPLEXER [=n]
>> │ Type  : tristate
>> │ Defined at drivers/mux/Kconfig:6
>> │   Prompt: Generic Multiplexer Support
>> │   Visible if: COMPILE_TEST [=n]
>>
>> This means it cannot be selected.
> Looks like you haven't enabled COMPILE_TEST first?
Correct.
But CONFIG_MULTIPLEXER should be visible always,
not just when COMPILE_TEST is set.
>
>> Instead I (think I) should use
>> default m if COMPILE_TEST
> No, merely enabling COMPILE_TEST must not enable additional
> functionality.
>
>> Since my patch-set broke x86_64 allmodconfig and failed merge into
>> linux-next,
>> this presents an opportunity to change the above as well with v9.
> Ulf has already applied this series to mmc/next.
What would be the process to fix the build error for x86_64 allmodconfig 
now?
>
> Gr{oetje,eeting}s,
>
>                          Geert
>


  reply	other threads:[~2026-02-09 10:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 13:01 [PATCH v8 0/7] mmc: host: renesas_sdhi_core: support configuring an optional sdio mux Josua Mayer
2026-02-03 13:01 ` [PATCH v8 1/7] phy: can-transceiver: rename temporary helper function to avoid conflict Josua Mayer
2026-02-04 15:18   ` Wolfram Sang
2026-02-03 13:01 ` [PATCH v8 2/7] mux: Add helper functions for getting optional and selected mux-state Josua Mayer
2026-02-03 15:35   ` Josua Mayer
2026-02-04 14:21     ` Ulf Hansson
2026-02-04 15:19   ` Wolfram Sang
2026-02-03 13:01 ` [PATCH v8 3/7] mux: add help text for MULTIPLEXER config option Josua Mayer
2026-02-04 15:19   ` Wolfram Sang
2026-02-08 15:16   ` Josua Mayer
2026-02-09  8:06     ` Geert Uytterhoeven
2026-02-09 10:12       ` Josua Mayer [this message]
2026-02-09 10:17         ` Geert Uytterhoeven
2026-02-09 10:47           ` Josua Mayer
2026-02-09 11:03             ` Geert Uytterhoeven
2026-02-03 13:01 ` [PATCH v8 4/7] phy: can-transceiver: drop temporary helper getting optional mux-state Josua Mayer
2026-02-04 15:19   ` Wolfram Sang
2026-02-03 13:01 ` [PATCH v8 5/7] i2c: omap: switch to new generic helper for getting selected mux-state Josua Mayer
2026-02-04 15:20   ` Wolfram Sang
2026-02-03 13:01 ` [PATCH v8 6/7] dt-bindings: mmc: renesas,sdhi: Add mux-states property Josua Mayer
2026-02-04 15:20   ` Wolfram Sang
2026-02-03 13:01 ` [PATCH v8 7/7] mmc: host: renesas_sdhi_core: support selecting an optional mux Josua Mayer
2026-02-04 15:20   ` Wolfram Sang
2026-02-04 15:47   ` Wolfram Sang
2026-02-04 15:33 ` [PATCH v8 0/7] mmc: host: renesas_sdhi_core: support configuring an optional sdio mux Ulf Hansson
2026-02-12 10:54   ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39f3891c-c05a-4e10-9ad4-ab3cbc6fa70e@solid-run.com \
    --to=josua@solid-run.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=andi.shyti@kernel.org \
    --cc=andreas@kemnade.info \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=jmkrzyszt@gmail.com \
    --cc=jon@solid-run.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mailhol@kernel.org \
    --cc=mikhail.anikin@solid-run.com \
    --cc=mkl@pengutronix.de \
    --cc=neil.armstrong@linaro.org \
    --cc=peda@axentia.se \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=tony@atomide.com \
    --cc=ulf.hansson@linaro.org \
    --cc=vigneshr@ti.com \
    --cc=vkoul@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yazan.shhady@solid-run.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox