From: "Jeff V. Merkey" <jmerkey@timpanogas.org>
To: "H. Peter Anvin" <hpa@transmeta.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-gcc@vger.kernel.org
Subject: Re: asm/resource.h
Date: Fri, 03 Nov 2000 14:29:50 -0700 [thread overview]
Message-ID: <3A032E4E.A08DC0EB@timpanogas.org> (raw)
In-Reply-To: <3A032C1D.D50C8D46@transmeta.com>
hpa,
Is this what is causing the lockup problems on 2.4.0-pre-10 with PPro,
or something else. Looks like something else.
Jeff
"H. Peter Anvin" wrote:
>
> Hello friends,
>
> Attached is a patch against 2.4.0-test10 that changes asm/resource.h to
> define RLIM_INFINITY insite the #ifdef __KERNEL__ on all architectures;
> previously, this was inconsistent between architecures. This breaks
> compilation with -Werror at least on i386 since <bits/resource.h>
> includes <asm/resource.h>, at least on glibc-2.1.2.
>
> I have only been able to test this on i386 and glibc 2.1.2. If there are
> any places where this change is *not* appropriate, now would be a good
> time to holler...
>
> -hpa
>
> --
> <hpa@transmeta.com> at work, <hpa@zytor.com> in private!
> "Unix gives you enough rope to shoot yourself in the foot."
> http://www.zytor.com/~hpa/puzzle.txt
>
> ------------------------------------------------------------------------
> diff -ur linux-2.4.0-test10-orig/include/asm/resource.h linux-2.4.0-test10/include/asm/resource.h
> --- linux-2.4.0-test10-orig/include/asm/resource.h Fri Sep 22 14:21:19 2000
> +++ linux-2.4.0-test10/include/asm/resource.h Fri Nov 3 13:11:12 2000
> @@ -19,13 +19,13 @@
>
> #define RLIM_NLIMITS 11
>
> +#ifdef __KERNEL__
> +
> /*
> * SuS says limits have to be unsigned.
> * Which makes a ton more sense anyway.
> */
> #define RLIM_INFINITY (~0UL)
> -
> -#ifdef __KERNEL__
>
> #define INIT_RLIMITS \
> { \
> diff -ur linux-2.4.0-test10-orig/include/asm-alpha/resource.h linux-2.4.0-test10/include/asm-alpha/resource.h
> --- linux-2.4.0-test10-orig/include/asm-alpha/resource.h Wed Sep 27 13:39:23 2000
> +++ linux-2.4.0-test10/include/asm-alpha/resource.h Fri Nov 3 13:11:30 2000
> @@ -19,14 +19,14 @@
>
> #define RLIM_NLIMITS 11
>
> +#ifdef __KERNEL__
> +
> /*
> * SuS says limits have to be unsigned. Fine, it's unsigned, but
> * we retain the old value for compatibility, especially with DU.
> * When you run into the 2^63 barrier, you call me.
> */
> #define RLIM_INFINITY 0x7ffffffffffffffful
> -
> -#ifdef __KERNEL__
>
> #define INIT_RLIMITS \
> { \
> diff -ur linux-2.4.0-test10-orig/include/asm-i386/resource.h linux-2.4.0-test10/include/asm-i386/resource.h
> --- linux-2.4.0-test10-orig/include/asm-i386/resource.h Fri Sep 22 14:21:19 2000
> +++ linux-2.4.0-test10/include/asm-i386/resource.h Fri Nov 3 13:11:12 2000
> @@ -19,13 +19,13 @@
>
> #define RLIM_NLIMITS 11
>
> +#ifdef __KERNEL__
> +
> /*
> * SuS says limits have to be unsigned.
> * Which makes a ton more sense anyway.
> */
> #define RLIM_INFINITY (~0UL)
> -
> -#ifdef __KERNEL__
>
> #define INIT_RLIMITS \
> { \
> diff -ur linux-2.4.0-test10-orig/include/asm-ia64/resource.h linux-2.4.0-test10/include/asm-ia64/resource.h
> --- linux-2.4.0-test10-orig/include/asm-ia64/resource.h Fri Sep 22 14:21:19 2000
> +++ linux-2.4.0-test10/include/asm-ia64/resource.h Fri Nov 3 13:11:04 2000
> @@ -22,13 +22,13 @@
>
> #define RLIM_NLIMITS 11
>
> +# ifdef __KERNEL__
> +
> /*
> * SuS says limits have to be unsigned.
> * Which makes a ton more sense anyway.
> */
> #define RLIM_INFINITY (~0UL)
> -
> -# ifdef __KERNEL__
>
> #define INIT_RLIMITS \
> { \
> diff -ur linux-2.4.0-test10-orig/include/asm-m68k/resource.h linux-2.4.0-test10/include/asm-m68k/resource.h
> --- linux-2.4.0-test10-orig/include/asm-m68k/resource.h Fri Sep 22 14:21:20 2000
> +++ linux-2.4.0-test10/include/asm-m68k/resource.h Fri Nov 3 13:10:54 2000
> @@ -19,13 +19,13 @@
>
> #define RLIM_NLIMITS 11
>
> +#ifdef __KERNEL__
> +
> /*
> * SuS says limits have to be unsigned.
> * Which makes a ton more sense anyway.
> */
> #define RLIM_INFINITY (~0UL)
> -
> -#ifdef __KERNEL__
>
> #define INIT_RLIMITS \
> { \
> diff -ur linux-2.4.0-test10-orig/include/asm-mips/resource.h linux-2.4.0-test10/include/asm-mips/resource.h
> --- linux-2.4.0-test10-orig/include/asm-mips/resource.h Fri Sep 22 14:21:20 2000
> +++ linux-2.4.0-test10/include/asm-mips/resource.h Fri Nov 3 13:10:44 2000
> @@ -26,13 +26,13 @@
>
> #define RLIM_NLIMITS 11 /* Number of limit flavors. */
>
> +#ifdef __KERNEL__
> +
> /*
> * SuS says limits have to be unsigned.
> * Which makes a ton more sense anyway.
> */
> #define RLIM_INFINITY 0x7fffffffUL
> -
> -#ifdef __KERNEL__
>
> #define INIT_RLIMITS \
> { \
> diff -ur linux-2.4.0-test10-orig/include/asm-mips64/resource.h linux-2.4.0-test10/include/asm-mips64/resource.h
> --- linux-2.4.0-test10-orig/include/asm-mips64/resource.h Fri Sep 22 14:21:20 2000
> +++ linux-2.4.0-test10/include/asm-mips64/resource.h Fri Nov 3 13:10:30 2000
> @@ -27,13 +27,13 @@
>
> #define RLIM_NLIMITS 11 /* Number of limit flavors. */
>
> +#ifdef __KERNEL__
> +
> /*
> * SuS says limits have to be unsigned.
> * Which makes a ton more sense anyway.
> */
> #define RLIM_INFINITY (~0UL)
> -
> -#ifdef __KERNEL__
>
> #define INIT_RLIMITS \
> { \
> diff -ur linux-2.4.0-test10-orig/include/asm-s390/resource.h linux-2.4.0-test10/include/asm-s390/resource.h
> --- linux-2.4.0-test10-orig/include/asm-s390/resource.h Fri Sep 22 14:21:21 2000
> +++ linux-2.4.0-test10/include/asm-s390/resource.h Fri Nov 3 13:10:13 2000
> @@ -27,13 +27,13 @@
>
> #define RLIM_NLIMITS 11
>
> +#ifdef __KERNEL__
> +
> /*
> * SuS says limits have to be unsigned.
> * Which makes a ton more sense anyway.
> */
> #define RLIM_INFINITY (~0UL)
> -
> -#ifdef __KERNEL__
>
> #define INIT_RLIMITS \
> { \
> diff -ur linux-2.4.0-test10-orig/include/asm-sparc/resource.h linux-2.4.0-test10/include/asm-sparc/resource.h
> --- linux-2.4.0-test10-orig/include/asm-sparc/resource.h Tue Oct 10 10:33:52 2000
> +++ linux-2.4.0-test10/include/asm-sparc/resource.h Fri Nov 3 13:09:46 2000
> @@ -25,6 +25,8 @@
>
> #define RLIM_NLIMITS 11
>
> +#ifdef __KERNEL__
> +
> /*
> * SuS says limits have to be unsigned.
> * We make this unsigned, but keep the
> @@ -32,7 +34,6 @@
> */
> #define RLIM_INFINITY 0x7fffffff
>
> -#ifdef __KERNEL__
> #define INIT_RLIMITS \
> { \
> {RLIM_INFINITY, RLIM_INFINITY}, \
> diff -ur linux-2.4.0-test10-orig/include/asm-sparc64/resource.h linux-2.4.0-test10/include/asm-sparc64/resource.h
> --- linux-2.4.0-test10-orig/include/asm-sparc64/resource.h Tue Oct 10 10:33:52 2000
> +++ linux-2.4.0-test10/include/asm-sparc64/resource.h Fri Nov 3 13:09:29 2000
> @@ -25,13 +25,14 @@
>
> #define RLIM_NLIMITS 11
>
> +#ifdef __KERNEL__
> +
> /*
> * SuS says limits have to be unsigned.
> * Which makes a ton more sense anyway.
> */
> #define RLIM_INFINITY (~0UL)
>
> -#ifdef __KERNEL__
> #define INIT_RLIMITS \
> { \
> {RLIM_INFINITY, RLIM_INFINITY}, \
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-03 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-03 21:20 asm/resource.h H. Peter Anvin
2000-11-03 21:29 ` Jeff V. Merkey [this message]
2000-11-04 2:33 ` asm/resource.h Peter Samuelson
2000-11-04 21:37 ` asm/resource.h Jeff V. Merkey
2000-11-04 20:58 ` asm/resource.h Peter Samuelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A032E4E.A08DC0EB@timpanogas.org \
--to=jmerkey@timpanogas.org \
--cc=hpa@transmeta.com \
--cc=linux-gcc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox