Re: Locking Between User Context and Soft IRQs in 2.4.0

Jeff Garzik
2000-11-06T12:50:15Z

Keith Owens wrote:
>
> On Mon, 06 Nov 2000 05:05:42 -0500,
> Jeff Garzik <jgarzik@mandrakesoft.com> wrote:
> >With the latest patch I've seen, there is no -need- to
> >immediately update the drivers. Once the patch is applied, I can clean
> >the drivers while I'm cleaning up request_region and the other stuff.
>
> I prefer a requirement that all net drivers upgrade to the new
> interface, otherwise we have odd drivers using the old interface
> forever and being at risk of module unload. That is why I coded my
> patch as returning -ENODEV if there was no dev->open. However I have
> to accept that just before a 2.4 release is not the best time to have a
> flag day. Put it down for 2.5.

What is "it" that gets put off until 2.5? Breaking net drivers with an
interface upgrade, or eliminating this race?

I would prefer that 2.4.0 went out the door with a race-free netdev
interface.

Andrew's patch is nice and small, and doesn't -require- a driver
upgrade. We can upgrade the important drivers now, and then do all the
stinkbomb crapola drivers during the 2.4.x series or whenever.

There is absolutely no need to break drivers for this. Not only is it
needless pain, but doing so is inconsistent -- with struct
file_operations, I am free to have owner==NULL.

Jeff

--
Jeff Garzik | "When I do this, my computer freezes."
Building 1024 | -user
MandrakeSoft | "Don't do that."
| -level 1