From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Bartlomiej Zolnierkiewicz <dake@staszic.waw.pl>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] media/radio [check_region() removal... ]
Date: Wed, 08 Nov 2000 23:02:06 -0500 [thread overview]
Message-ID: <3A0A21BE.8934BEE1@mandrakesoft.com> (raw)
In-Reply-To: <Pine.LNX.4.21.0011090124350.23238-100000@tricky>
Bartlomiej Zolnierkiewicz wrote:
>
> On Wed, 8 Nov 2000, Jeff Garzik wrote:
>
> > Patch looks generally ok. Some of the whitespace/formatting changes are
> > questionable, I usually leave that up to the maintainer unless it is
> > very gratuitously opposite to CodingStyle.
> >
>
> These drivers seem to be unmantained :)
> Anyway if this is a problem I can undo these changes ...
I don't have any problem with them. Make sure you CC the individual
maintainers of the drivers... some of the pop up every now and then :)
> > Some of the driver messages ("foo version 1.0") are purposefully printed
> > -after-, not before, the device is probed and registered. Your patch
> > gets this wrong in at least one place.
> >
>
> Yes... I wasn't sure about this... can undo...
When in doubt, follow the behavior of the existing driver. :)
Especially since we're in a freeze, and stuff...
--
Jeff Garzik |
Building 1024 | Would you like a Twinkie?
MandrakeSoft |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-11-09 4:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-11-09 0:03 [PATCH] media/radio [check_region() removal... ] Bartlomiej Zolnierkiewicz
2000-11-09 0:13 ` Jeff Garzik
2000-11-09 0:29 ` Bartlomiej Zolnierkiewicz
2000-11-09 4:02 ` Jeff Garzik [this message]
2000-11-09 13:06 ` Andrey Panin
2000-11-09 13:08 ` Jeff Garzik
2000-11-09 13:37 ` Alan Cox
2000-11-09 13:50 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2000-11-09 15:36 Russell Kroll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A0A21BE.8934BEE1@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dake@staszic.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox