Re: [patch] NE2000

[Tom Leete <tleete@mountain.net>]

"David S. Miller" wrote:
> 
>    Date: Thu, 09 Nov 2000 21:53:42 +1100
>    From: Andrew Morton <andrewm@uow.edu.au>
> 
>    "David S. Miller" wrote:
>    > I will compose a patch to fix all this.
> 
>    I've quickly been through just about all of the kernel wrt
>    waitqueues.
> 
> My analysis was in error, BEWARE!
> 
> Being on multiple wait queues at once is just fine.  I verified this
> with Linus tonight.
> 
> The problem case is in mixing TASK_EXCLUSIVE and non-TASK_EXCLUSIVE
> sleeps, that is what can actually cause problems.
> 
> Everything else is fine.  Anyways, the (untested) patch below should
> cure the lock_sock() cases.
> 
> --- ./net/ipv4/af_inet.c.~1~    Tue Oct 24 14:26:18 2000
> +++ ./net/ipv4/af_inet.c        Wed Nov  8 17:28:47 2000
[...]
> --- ./net/ipv4/tcp.c.~1~        Fri Oct  6 15:45:41 2000
> +++ ./net/ipv4/tcp.c    Wed Nov  8 17:35:31 2000

This touches the places where I saw hangs, so I'm testing.
Too soon to have statistics, but with this patch I have
observed no more failures to wake (what I referred  to as
"soft hangs").

I have seen a total I/O lockup, but no info escapes to
indicate its source. No NMI wakeup available, maybe I should
rig a pushbutton.

Tom
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/