Re: [PATCH] CONFIG_EISA note in Documentation/Configure.help

[Jeff Garzik <jgarzik@mandrakesoft.com>]

Steven Cole wrote:
> Well, the CONFIG_EISA option is there.  My little patch was just intended to
> slightly enlighten those prone to "lets see what this option does".  I
> compiled test11-pre4 both with and without CONFIG_EISA and the difference is
> very slight.  Of course, if you had more items with EISA code, this difference
> would be bigger.
> 
>  848 -rw-r--r--    1 root     root       868179 Nov 14 13:32 bzImage
>  848 -rw-r--r--    1 root     root       867973 Nov 14 13:28 bzImage.no_eisa
> 
> The difference probably comes from my 3c59x driver.
> 
> I also uglied up the 3c59x.c code with #ifdef CONFIG_EISA around the
> six sections relavant to EISA to see if that would save anything, and the
> object file was only 318 bytes smaller, probably not worth the uglyness of
> the six ifdefs.  That modified code was not used in the above comparison.

When !CONFIG_EISA, the global variable 'EISA_bus' is unconditionally
zero.  Therefore you merely need to test EISA_bus, as existing code
already should be doing..  As for 3c59x patches, they should go to the
maintainer, Andrew Morton..

	Jeff


-- 
Jeff Garzik             |
Building 1024           | The chief enemy of creativity is "good" sense
MandrakeSoft            |          -- Picasso
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/