Re: 2.4.0-test11-pre6 fails compile (dev.c)

[Jeff Garzik <jgarzik@mandrakesoft.com>]

Neil Brown wrote:
> 
> On Thursday November 16, clem@clem.digital.net wrote:
> > FYI:
> >
> > gcc -D__KERNEL__ -I/usr/src/linux-2.4.0-test11/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=i686    -c -o dev.o dev.c
> > dev.c: In function `run_sbin_hotplug':
> > dev.c:2736: `hotplug_path' undeclared (first use in this function)
> > dev.c:2736: (Each undeclared identifier is reported only once
> > dev.c:2736: for each function it appears in.)
> > make[3]: *** [dev.o] Error 1
> > make[3]: Leaving directory `/sda3/usr/src/linux-2.4.0-test11/net/core'
> > make[2]: *** [first_rule] Error 2

> The following works for me.... and even looks right.

Thanks for taking care of one of my "fix after applying" items :)

Looks ok to me, though I prefer that #endif include a comment following
it that names the cpp symbol it encloses.  Applied...

	Jeff


-- 
Jeff Garzik             |
Building 1024           | The chief enemy of creativity is "good" sense
MandrakeSoft            |          -- Picasso
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/