duplicate entries in rtl8129 driver

duplicate entries in rtl8129 driver

[Adam J. Richter]

	Both linux-2.4.0-test12-pre6/drivers/net/rtl8129.c and
Don Becker's version at ftp.sycld.com appear to have identical
PCI device ID and vendor ID values for these two cards:

		SMC1211TX EZCard 10/100 (RealTek RTL8139)
		Accton MPX5030 (RealTek RTL8139)

	So, I do not see how the latter entry in pci_tbl is ever
matched.  I think the result would be that users of either card
will be told that they have an SMC1211TX EZCard 10/100.  I suggest
deleting the latter entry and combine its label into the previous
one, so it will be described as:

	SMC1211TX EZCard 10/100 or Accton MPX5030 (RealTek RTL8139)

	Comments?

Adam J. Richter     __     ______________   4880 Stevens Creek Blvd, Suite 104
adam@yggdrasil.com     \ /                  San Jose, California 95129-1034
+1 408 261-6630         | g g d r a s i l   United States of America
fax +1 408 261-6631      "Free Software For The Rest Of Us."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: duplicate entries in rtl8129 driver

[Donald Becker]

On Fri, 17 Nov 2000, Adam J. Richter wrote:

> 	Both linux-2.4.0-test12-pre6/drivers/net/rtl8129.c and
> Don Becker's version at ftp.sycld.com appear to have identical
> PCI device ID and vendor ID values for these two cards:
> 
> 		SMC1211TX EZCard 10/100 (RealTek RTL8139)
> 		Accton MPX5030 (RealTek RTL8139)
> 
> 	So, I do not see how the latter entry in pci_tbl is ever
> matched.  I think the result would be that users of either card
> will be told that they have an SMC1211TX EZCard 10/100.  I suggest
> deleting the latter entry and combine its label into the previous
> one, so it will be described as:
> 
> 	SMC1211TX EZCard 10/100 or Accton MPX5030 (RealTek RTL8139)

They are distinguished by the PCI subsystem ID, which was truncated from the
list.

Note that Accton is really SMC.  They purchased part of SMC several years
ago, including the brand name.  The chip part of the old SMC is now named
SMsC, and they still make the EPIC Ethernet chip.

I do have a long list of subsystem IDs, but using multiple names for a
one-chip board with no design options is just confusing.  (Vs. the 21143
chip, which has at least 70 different driver-visible board design
variations.)

Bottom line: Yes, it's redundant.  But there was a reason.

Donald Becker				becker@scyld.com
Scyld Computing Corporation		http://www.scyld.com
410 Severn Ave. Suite 210		Second Generation Beowulf Clusters
Annapolis MD 21403			410-990-9993

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: duplicate entries in rtl8129 driver

[Jeff Garzik]

"Adam J. Richter" wrote:
> 
>         Both linux-2.4.0-test12-pre6/drivers/net/rtl8129.c and
> Don Becker's version at ftp.sycld.com appear to have identical
> PCI device ID and vendor ID values for these two cards:

rtl8129 is going away as soon as humanly possible.  :)  RealTek sent me
a RTL8130 so I can test the MII stuff finally.

Note that those duplicate ids should be commented out of rtl8129.c,
also.

-- 
Jeff Garzik             |
Building 1024           | The chief enemy of creativity is "good" sense
MandrakeSoft            |          -- Picasso
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/