public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Bartlomiej Zolnierkiewicz <dake@staszic.waw.pl>
Cc: torvalds@transmeta.com, andre@linux-ide.org,
	linux-kernel@vger.kernel.org
Subject: Re: [uPATCH] fix IDE/ServerWorks OSB4 config option (test11)
Date: Tue, 21 Nov 2000 16:55:38 -0500	[thread overview]
Message-ID: <3A1AEF5A.C141C5F3@mandrakesoft.com> (raw)
In-Reply-To: <Pine.LNX.4.21.0011211522570.4622-100000@tricky>

Bartlomiej Zolnierkiewicz wrote:
> --- linux-240t11/drivers/ide/Config.in  Wed Nov 15 22:02:11 2000
> +++ linux/drivers/ide/Config.in Tue Nov 21 14:52:07 2000
> @@ -68,7 +68,7 @@
>             dep_bool '    OPTi 82C621 chipset enhanced support (EXPERIMENTAL)' CONFIG_BLK_DEV_OPTI621 $CONFIG_EXPERIMENTAL
>             dep_bool '    PROMISE PDC20246/PDC20262/PDC20267 support' CONFIG_BLK_DEV_PDC202XX $CONFIG_BLK_DEV_IDEDMA_PCI
>             dep_bool '      Special UDMA Feature' CONFIG_PDC202XX_BURST $CONFIG_BLK_DEV_PDC202XX
> -           dep_bool '    ServerWorks OSB4 chipset support' CONFIG_BLK_DEV_OSB4 $CONFIG_BLK_DEV_OSB4
> +           dep_bool '    ServerWorks OSB4 chipset support' CONFIG_BLK_DEV_OSB4 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
>             dep_bool '    SiS5513 chipset support' CONFIG_BLK_DEV_SIS5513 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
>             dep_bool '    SLC90E66 chipset support' CONFIG_BLK_DEV_SLC90E66 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86


Just wondering, why do these depend on CONFIG_X86?

I just glanced at osb4.c and it looks pretty well-written and portable
to me...  Nothing X86 specific about it.  Ditto some of the others
depending on CONFIG_X86.  IMHO even if the southbridge is currently only
known to be used on x86's, that doesn't mean that the hardware, or the
driver, will always be limited to the X86 platform.

	Jeff


-- 
Jeff Garzik             |
Building 1024           | The chief enemy of creativity is "good" sense
MandrakeSoft            |          -- Picasso
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2000-11-21 22:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-11-21 21:25 [uPATCH] fix IDE/ServerWorks OSB4 config option (test11) Bartlomiej Zolnierkiewicz
2000-11-21 21:55 ` Jeff Garzik [this message]
2000-11-22  1:14 ` Andre Hedrick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A1AEF5A.C141C5F3@mandrakesoft.com \
    --to=jgarzik@mandrakesoft.com \
    --cc=andre@linux-ide.org \
    --cc=dake@staszic.waw.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox