* [uPATCH] fix IDE/ServerWorks OSB4 config option (test11)
@ 2000-11-21 21:25 Bartlomiej Zolnierkiewicz
2000-11-21 21:55 ` Jeff Garzik
2000-11-22 1:14 ` Andre Hedrick
0 siblings, 2 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2000-11-21 21:25 UTC (permalink / raw)
To: torvalds; +Cc: andre, linux-kernel
Hi
In drivers/Config.in CONFIG_BLK_DEV_OSB4 depends on itself...
--
Bartlomiej Zolnierkiewicz
<bkz@linux-ide.org>
--- linux-240t11/drivers/ide/Config.in Wed Nov 15 22:02:11 2000
+++ linux/drivers/ide/Config.in Tue Nov 21 14:52:07 2000
@@ -68,7 +68,7 @@
dep_bool ' OPTi 82C621 chipset enhanced support (EXPERIMENTAL)' CONFIG_BLK_DEV_OPTI621 $CONFIG_EXPERIMENTAL
dep_bool ' PROMISE PDC20246/PDC20262/PDC20267 support' CONFIG_BLK_DEV_PDC202XX $CONFIG_BLK_DEV_IDEDMA_PCI
dep_bool ' Special UDMA Feature' CONFIG_PDC202XX_BURST $CONFIG_BLK_DEV_PDC202XX
- dep_bool ' ServerWorks OSB4 chipset support' CONFIG_BLK_DEV_OSB4 $CONFIG_BLK_DEV_OSB4
+ dep_bool ' ServerWorks OSB4 chipset support' CONFIG_BLK_DEV_OSB4 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
dep_bool ' SiS5513 chipset support' CONFIG_BLK_DEV_SIS5513 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
dep_bool ' SLC90E66 chipset support' CONFIG_BLK_DEV_SLC90E66 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
dep_bool ' Tekram TRM290 chipset support (EXPERIMENTAL)' CONFIG_BLK_DEV_TRM290 $CONFIG_BLK_DEV_IDEDMA_PCI
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [uPATCH] fix IDE/ServerWorks OSB4 config option (test11)
2000-11-21 21:25 [uPATCH] fix IDE/ServerWorks OSB4 config option (test11) Bartlomiej Zolnierkiewicz
@ 2000-11-21 21:55 ` Jeff Garzik
2000-11-22 1:14 ` Andre Hedrick
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2000-11-21 21:55 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: torvalds, andre, linux-kernel
Bartlomiej Zolnierkiewicz wrote:
> --- linux-240t11/drivers/ide/Config.in Wed Nov 15 22:02:11 2000
> +++ linux/drivers/ide/Config.in Tue Nov 21 14:52:07 2000
> @@ -68,7 +68,7 @@
> dep_bool ' OPTi 82C621 chipset enhanced support (EXPERIMENTAL)' CONFIG_BLK_DEV_OPTI621 $CONFIG_EXPERIMENTAL
> dep_bool ' PROMISE PDC20246/PDC20262/PDC20267 support' CONFIG_BLK_DEV_PDC202XX $CONFIG_BLK_DEV_IDEDMA_PCI
> dep_bool ' Special UDMA Feature' CONFIG_PDC202XX_BURST $CONFIG_BLK_DEV_PDC202XX
> - dep_bool ' ServerWorks OSB4 chipset support' CONFIG_BLK_DEV_OSB4 $CONFIG_BLK_DEV_OSB4
> + dep_bool ' ServerWorks OSB4 chipset support' CONFIG_BLK_DEV_OSB4 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
> dep_bool ' SiS5513 chipset support' CONFIG_BLK_DEV_SIS5513 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
> dep_bool ' SLC90E66 chipset support' CONFIG_BLK_DEV_SLC90E66 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
Just wondering, why do these depend on CONFIG_X86?
I just glanced at osb4.c and it looks pretty well-written and portable
to me... Nothing X86 specific about it. Ditto some of the others
depending on CONFIG_X86. IMHO even if the southbridge is currently only
known to be used on x86's, that doesn't mean that the hardware, or the
driver, will always be limited to the X86 platform.
Jeff
--
Jeff Garzik |
Building 1024 | The chief enemy of creativity is "good" sense
MandrakeSoft | -- Picasso
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [uPATCH] fix IDE/ServerWorks OSB4 config option (test11)
2000-11-21 21:25 [uPATCH] fix IDE/ServerWorks OSB4 config option (test11) Bartlomiej Zolnierkiewicz
2000-11-21 21:55 ` Jeff Garzik
@ 2000-11-22 1:14 ` Andre Hedrick
1 sibling, 0 replies; 3+ messages in thread
From: Andre Hedrick @ 2000-11-22 1:14 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: torvalds, linux-kernel
Oh well mistakes in Config are okay and not fatal.
Thanks for the find Bart.
Cheers,
On Tue, 21 Nov 2000, Bartlomiej Zolnierkiewicz wrote:
>
> Hi
>
> In drivers/Config.in CONFIG_BLK_DEV_OSB4 depends on itself...
>
> --
> Bartlomiej Zolnierkiewicz
> <bkz@linux-ide.org>
>
> --- linux-240t11/drivers/ide/Config.in Wed Nov 15 22:02:11 2000
> +++ linux/drivers/ide/Config.in Tue Nov 21 14:52:07 2000
> @@ -68,7 +68,7 @@
> dep_bool ' OPTi 82C621 chipset enhanced support (EXPERIMENTAL)' CONFIG_BLK_DEV_OPTI621 $CONFIG_EXPERIMENTAL
> dep_bool ' PROMISE PDC20246/PDC20262/PDC20267 support' CONFIG_BLK_DEV_PDC202XX $CONFIG_BLK_DEV_IDEDMA_PCI
> dep_bool ' Special UDMA Feature' CONFIG_PDC202XX_BURST $CONFIG_BLK_DEV_PDC202XX
> - dep_bool ' ServerWorks OSB4 chipset support' CONFIG_BLK_DEV_OSB4 $CONFIG_BLK_DEV_OSB4
> + dep_bool ' ServerWorks OSB4 chipset support' CONFIG_BLK_DEV_OSB4 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
> dep_bool ' SiS5513 chipset support' CONFIG_BLK_DEV_SIS5513 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
> dep_bool ' SLC90E66 chipset support' CONFIG_BLK_DEV_SLC90E66 $CONFIG_BLK_DEV_IDEDMA_PCI $CONFIG_X86
> dep_bool ' Tekram TRM290 chipset support (EXPERIMENTAL)' CONFIG_BLK_DEV_TRM290 $CONFIG_BLK_DEV_IDEDMA_PCI
>
>
Andre Hedrick
CTO Timpanogas Research Group
EVP Linux Development, TRG
Linux ATA Development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2000-11-22 1:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2000-11-21 21:25 [uPATCH] fix IDE/ServerWorks OSB4 config option (test11) Bartlomiej Zolnierkiewicz
2000-11-21 21:55 ` Jeff Garzik
2000-11-22 1:14 ` Andre Hedrick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox