Re: ext2 filesystem corruptions back from dead? 2.4.0-test11

Neil Brown
2000-11-23T12:43:11Z

On Thursday November 23, neilb@cse.unsw.edu.au wrote:
> On Thursday November 23, viro@math.psu.edu wrote:
> >
> > Guys, could you try to reproduce it with the following:
>
> Well, I tried.... but it didn't go real well.
>
.....
> It looks like extending a file is not allowed any more.
>
> This is with 2.4.0-test11 plus assorted patches to knfsd (which should
> be totally irrelevant) and raid5 (Which should not affect ext2), plus
> your patch, which applied cleanly.
>
> I'll try with a clean test11 plus your patches in the morning, but it
> doesn't look good.
>
> NeilBrown

It appears that lots of files have been marked "immutable" :-(

That patch contained

@@ -110,4 +99,5 @@

struct inode_operations ext2_file_inode_operations = {
truncate: ext2_truncate,
+ setattr: ext2_notify_change,
};

which enabled ext2_notify_change, however ext2_notify_change has a
bug.
It sets attributes from iattr->ia_attr_flags even
if ATTR_ATTR_FLAG is NOT SET in iattr->ia_valid.

NeilBrown