Re: [2*PATCH] alpha I/O access and mb()

[Abramo Bagnara <abramo@alsa-project.org>]

Before of all I want to publicly apologize with Richard as never my
intention was to exacerbate him.

> 
> On Sun, Dec 10, 2000 at 10:23:20PM +0100, Abramo Bagnara wrote:
> > asm/io.h uses out of line function only when CONFIG_ALPHA_GENERIC is
> > defined, otherwise it uses (take writel as an example) __raw_writel that
> > IMHO need to be defined in core_t2.h.
> 
> Perhaps you should _show_ an actual failure rather than just guessing.

I've not access to this specific hardware but I was trying to fix the
alpha case wrt write[bwlq] function as I've had a lot of trouble with
ALSA drivers and 2.2 (that still now is broken wrt mb() and I've sent a
patch to Alpha Processor guys). This is the reason why I've given a look
to 2.4.

> 
> You are wildly incorrect asserting that out of line functions are used
> only with CONFIG_ALPHA_GENERIC.  You should examine
> 
> #ifndef __raw_writel
> # define __raw_writel(v,a)  ___raw_writel((v),(unsigned long)(a))
> #endif
> 
> and suchlike definitions.

Now I understand, thanks.

I see that some core*.h leaves out of line some functions because they
are more complex than a choosen threshold.

-- 
Abramo Bagnara                       mailto:abramo@alsa-project.org

Opera Unica                          Phone: +39.546.656023
Via Emilia Interna, 140
48014 Castel Bolognese (RA) - Italy

ALSA project is            http://www.alsa-project.org
sponsored by SuSE Linux    http://www.suse.com

It sounds good!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/