Re: PATCH: linux-2.4.0-test12pre8/include/linux/module.h breaks sysklogd compilation

Keith Owens
2000-12-12T01:37:00Z

On Mon, 11 Dec 2000 14:59:01 -0800,
"Adam J. Richter" <adam@yggdrasil.com> wrote:
> linux-2.4.0test12pre8/include/linux/module.h contains some
>kernel-specific declarations that now reference struct list_head, which
>which is only defined when __KERNEL__ is set. This causes sysklogd
>and probably any other user level program that needs to include
><linux/module.h> to fail to compile.
>
> The following patch brackets the (unused) offending declarations
>in #ifdef __KERNEL__...#endif.

Linus, please do not apply.

User space applications _must_ not include kernel headers. Even
modutils does not include linux/module.h, it has its own portable
(kernels 2.0 - 2.4) version.

I have strongly recommended to the sysklogd maintainers that they strip
all the symbol handling from klogd. The oops decoding in klogd is
hopelessly out of date and broken.