public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bruce Korb <bkorb@cruzio.com>
To: Lukasz Trabinski <lukasz@lt.wsisiz.edu.pl>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
	tytso@valinux.com
Subject: Re: [patch] 2.2.18 PCI_DEVICE_ID_OXSEMI_16PCI954
Date: Fri, 15 Dec 2000 15:04:46 -0800	[thread overview]
Message-ID: <3A3AA38E.A6A13759@cruzio.com> (raw)
In-Reply-To: <Pine.LNX.4.30.0012152140350.3740-100000@lt.wsisiz.edu.pl>

Lukasz Trabinski wrote:
> include/linux/pci_ids.h:#define PCI_DEVICE_ID_OXSEMI_16PCI954   0x9501
> 
> (IMHO that is correct), but in kernel 2.2.18 we have:
> (include/kernel/pci.h)
> #define PCI_DEVICE_ID_OXSEMI_16PCI954PP        0x9513
>                                      ^^
> 
> Please correct, if I'm wrong, but IMHO it shuld be:
> (include/kernel/pci.h)
> #define PCI_DEVICE_ID_OXSEMI_16PCI954  0x9513

Please correct me if *I* am wrong, but shouldn't the names be
different if the values are different?

Also, excuse me while I soap-box for a moment:  This and other
inconsistencies
would be easier to deal with if there were a single repository for PCI
information from which all the PCI device tables and ID enumerations
were derived.  I have posted the technology that can easily be adapted
to emit both 2.2 and 2.4 flavors of tables, though only PCI-IDE stuff
for 2.4 is currently implemented.

  See  ftp://autogen.linuxave.net/pub/PCIDEV.tgz

Tiny drawback:  you must download and use this to generate
all the output tables:

  ftp://autogen.linuxave.net/pub/autogen-5.1.3.tar.gz

Homepage (with broken download link due to SourceForge outage):

  http://AutoGen.SourceForge.net/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2000-12-15 23:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-12-15 20:57 [patch] 2.2.18 PCI_DEVICE_ID_OXSEMI_16PCI954 Lukasz Trabinski
2000-12-15 23:04 ` Bruce Korb [this message]
2000-12-16 23:21 ` Tim Waugh
2000-12-17  0:51   ` Lukasz Trabinski
2000-12-17 10:18     ` tytso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A3AA38E.A6A13759@cruzio.com \
    --to=bkorb@cruzio.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukasz@lt.wsisiz.edu.pl \
    --cc=tytso@valinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox