public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Juri Haberland <juri.haberland@innominate.com>
To: "Andreas M. Kirchwitz" <amk@krell.snafu.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix emu10k1 init breakage in 2.2.18
Date: Wed, 20 Dec 2000 10:44:21 +0100	[thread overview]
Message-ID: <3A407F75.2A8F5188@innominate.com> (raw)
In-Reply-To: <200012191201.NAA02004@harpo.it.uu.se> <slrn93vb44.enh.amk@krell.zikzak.de>

"Andreas M. Kirchwitz" wrote:
> 
> Mikael Pettersson wrote:
> 
>  > 2.2.18 broke the emu10k1 driver when compiled into the kernel.
>  > The problem is that 2.2.18 now implements 2.4-style module_init,
>  > so emu10k1 ended up being initialised twice when built non-modular,
>  > which rendered it dysfunctional. The fix is to remove the now
>  > obsolete explicit init calls. Patch below. Please apply.
> 
> Is there also a fix available to make the bass and treble settings
> work again in mixer applications (for example, Gnome mix 1.2.0)?
> This is (now, was) one of the biggest advantages of this card to have
> control over bass and treble settings.
> 
> It worked for the early 2.2.18pre patches, but stopped working in
> the latest ones (including final 2.2.18).

Yes, put something like "EXTRA_CFLAGS += -DTONE_CONTROL" into the
Makefile in drivers/sound/emu10k1/

Juri

-- 
juri.haberland@innominate.com
system engineer                                         innominate AG
clustering & security                            the linux architects
tel: +49-30-308806-45   fax: -77            http://www.innominate.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2000-12-20 10:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-12-19 12:01 [PATCH] fix emu10k1 init breakage in 2.2.18 Mikael Pettersson
2000-12-19 18:44 ` Andreas M. Kirchwitz
2000-12-20  9:44   ` Juri Haberland [this message]
2000-12-22  1:17     ` Andreas M. Kirchwitz
2000-12-20 20:58   ` kees

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3A407F75.2A8F5188@innominate.com \
    --to=juri.haberland@innominate.com \
    --cc=amk@krell.snafu.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox