From: Daniel Phillips <phillips@innominate.de>
To: Nathan Scott <nathans@wobbly.melbourne.sgi.com>,
linux-kernel@vger.kernel.org
Subject: Re: More better in mount(2)
Date: Fri, 05 Jan 2001 15:51:36 +0100 [thread overview]
Message-ID: <3A55DF78.F92AC570@innominate.de> (raw)
In-Reply-To: <NBBBJGOOMDFADJDGDCPHIEPACJAA.law@sgi.com> <10101051142.ZM11680@wobbly.melbourne.sgi.com> <01010503292006.00477@gimli> <10101051340.ZM14895@wobbly.melbourne.sgi.com>
Nathan Scott wrote:
> On Jan 5, 3:26am, Daniel Phillips wrote:
> > ...
> > This filesystem mount option parsing code is completely ad hoc, and uses
> > strtok which is horribly horribly broken. (Do man strtok and read the
> > 'Bugs' section.)
> >
> > It would be worth thinking about how to do this better.
>
> hmm ... can't claim I wrote this code, just looked at it.
> are you saying the kernel strtok is horribly broken or just
> the way its being used here? (and why?)
>From the man page:
BUGS Never use this function. If you do, note that:
This function modifies its first argument.
The identity of the delimiting character is lost.
This functions cannot be used on constant strings.
The strtok () function uses a static buffer while
parsing, so it's not thread safe. Use strtok_r ()
if this matters to
you.
--
Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next parent reply other threads:[~2001-01-05 14:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <NBBBJGOOMDFADJDGDCPHIEPACJAA.law@sgi.com>
[not found] ` <10101051142.ZM11680@wobbly.melbourne.sgi.com>
[not found] ` <01010503292006.00477@gimli>
[not found] ` <10101051340.ZM14895@wobbly.melbourne.sgi.com>
2001-01-05 14:51 ` Daniel Phillips [this message]
2001-01-05 20:26 ` More better in mount(2) Andreas Dilger
2001-01-08 14:06 ` xfs mount opts (was: More better in mount(2)) Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3A55DF78.F92AC570@innominate.de \
--to=phillips@innominate.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nathans@wobbly.melbourne.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox